Skip to content

skylib: Improve path.bzl%runfile to better integrate with runfiles li… #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

skylib: Improve path.bzl%runfile to better integrate with runfiles li… #2255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions skylib/path.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ def strip_prefix(path, prefix):

def runfile(ctx, f):
"""Return the runfiles relative path of f."""
if f.short_path[:3] == "../":
return f.short_path[3:]
if f.owner and f.owner.workspace_root:
return f.owner.workspace_root + "/" + f.short_path
if ctx.workspace_name:
return ctx.workspace_name + "/" + f.short_path
else:
Expand Down