Inconsistencies with null-coalescing wrapping on method chains

[SigtryggurO]

csharpier 0.30.6

Input:

var test4 =
    await context
        .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
        .FirstOrDefaultAsync(cancellationToken) ?? throw new Exception("This is an exception message");

Output:

var test4 =
    await context
        .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
        .FirstOrDefaultAsync(cancellationToken) ?? throw new Exception("This is an exception message");

Expected behavior:

var test4 =
    await context
        .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
        .FirstOrDefaultAsync(cancellationToken)
    ?? throw new Exception("This is an exception message");

On its own, this might seem fine, but when compared to a similar method where we modify different parts of the assignment, the inconsistency becomes apparent:

// Fully inline: short method chain and short exception message.
var test1 = await context.Images.FirstAsync(cancellationToken) ?? throw new Exception("This is an exception message");

// Break after '=', everything else fits on one line.
var test2_1 =
    await context.Images.FirstOrDefaultAsync(cancellationToken) ?? throw new Exception("This is an exception message");

// Similar to test2_1, slightly longer exception message but still contained in a single line.
var test2_2 =
    await context.Images.FirstAsync(cancellationToken) ?? throw new Exception("This is a longer exception message");

// Breaks after '=', and '??' is on a new line due to method length.
var test3_1 =
    await context.Images.FirstOrDefaultAsync(x => x.Id == ImageId.CreateUnique(), cancellationToken)
    ?? throw new Exception("This is an exception message");

// Similar to test3_1, but it wraps due to message length.
var test3_2 =
    await context.Images.FirstAsync(cancellationToken)
    ?? throw new Exception("This is a much longer exception message which should be long enough to wrap on its own");

// Multiline formatting: Last part of method chain is short and the exception message is short, so '??' is not wrapped, inconsistent with others.
var test4 =
    await context
        .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
        .FirstOrDefaultAsync(cancellationToken) ?? throw new Exception("This is an exception message");

// Multiline formatting: Last part of method chain is long, so '??' is wrapped.
var test5_1 =
    await context
        .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
        .FirstOrDefaultAsync(x => x.Id == ImageId.CreateUnique(), cancellationToken)
    ?? throw new Exception("This is an exception message");

// Multiline formatting: Exception message is long, so '??' is wrapped.
var test5_2 =
    await context
        .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
        .FirstOrDefaultAsync(cancellationToken)
    ?? throw new Exception("This is a much longer exception message which should be long enough to wrap on its own");

I also tried without assignment and swapped out throw for a static function with same results.

[belav]

Something else I changed seems to have corrected this formatting. This is the formatting as of 1.0.3

// Fully inline: short method chain and short exception message.
var test1 =
    await context.Images.FirstAsync(cancellationToken)
    ?? throw new Exception("This is an exception message");

// Break after '=', everything else fits on one line.
var test2_1 =
    await context.Images.FirstOrDefaultAsync(cancellationToken)
    ?? throw new Exception("This is an exception message");

// Similar to test2_1, slightly longer exception message but still contained in a single line.
var test2_2 =
    await context.Images.FirstAsync(cancellationToken)
    ?? throw new Exception("This is a little longer exception message");

// Breaks after '=', and '??' is on a new line due to method length.
var test3_1 =
    await context.Images.FirstOrDefaultAsync(x => x.Id == ImageId.CreateUnique(), cancellationToken)
    ?? throw new Exception("This is an exception message");

// Similar to test3_1, but it wraps due to message length.
var test3_2 =
    await context.Images.FirstAsync(cancellationToken)
    ?? throw new Exception(
        "This is a much longer exception message which should be long enough to wrap on its own"
    );

// Multiline formatting: Last part of method chain is short and the exception message is short, so '??' is not wrapped, inconsistent with others.
var test4 =
    await context
        .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
        .FirstOrDefaultAsync(cancellationToken)
    ?? throw new Exception("This is an exception message");

// Multiline formatting: Last part of method chain is long, so '??' is wrapped.
var test5_1 =
    await context
        .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
        .FirstOrDefaultAsync(x => x.Id == ImageId.CreateUnique(), cancellationToken)
    ?? throw new Exception("This is an exception message");

// Multiline formatting: Exception message is long, so '??' is wrapped.
var test5_2 =
    await context
        .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
        .FirstOrDefaultAsync(cancellationToken)
    ?? throw new Exception(
        "This is a much longer exception message which should be long enough to wrap on its own"
    );

[SigtryggurO]

This still seems to be an issue in 1.1.1

  ----------------------------- Expected: Around Line 56 -----------------------------
                      .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
                      .FirstOrDefaultAsync(cancellationToken) ?? throw new Exception("This is an exception message");

  ----------------------------- Actual: Around Line 56 -----------------------------
                      .Images.Where(x => x.Id == ImageId.CreateUnique() && x.Created == DateTime.MaxValue)
                      .FirstOrDefaultAsync(cancellationToken)
                  ?? throw new Exception("This is an exception message");

[SigtryggurO]

To replicate this issue correctly, the code stub should be a top-level statement and max_line_length = 120. This should have been noted in the original post.

[belav]

Ah yeah I think I was doing my testing with 100. I was able to replicate it now and got a fix for it that will be out shortly.