Skip to content

Conversation

evanlinjin
Copy link
Member

Fixes #2030

Description

This recipe verifies that a crate can be packaged and built in isolation (without workspace dependencies).

This is useful for ensuring updated crates do not accidentally depend on breaking changes in upstream crates of the same workspace.

Added alias vs for quick access to this commonly used verification step.

Checklists

All Submissions:

evanlinjin and others added 2 commits September 12, 2025 01:57
This recipe verifies that a crate can be packaged and built in isolation
(without workspace dependencies).

This is useful for ensuring updated crates do not accidentally depend on
breaking changes in upstream crates of the same workspace.

Added alias `vs` for quick access to this commonly used verification step.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Verifies all publishable workspace crates can build in isolation.
Added alias `vsa` for quick access.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@evanlinjin evanlinjin force-pushed the ci-verify-build-without-workspace branch from 54b0033 to 63595ee Compare September 12, 2025 02:54
@evanlinjin evanlinjin marked this pull request as ready for review September 12, 2025 02:57
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 63595ee

@evanlinjin evanlinjin force-pushed the ci-verify-build-without-workspace branch from 068e47c to 3fbf406 Compare September 12, 2025 03:09
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK 3fbf406

@evanlinjin evanlinjin self-assigned this Sep 12, 2025
@notmandatory notmandatory moved this to Needs Review in BDK Chain Sep 12, 2025
@notmandatory notmandatory added the chore Non-coding related work label Sep 12, 2025
@ValuedMammal
Copy link
Collaborator

Long term I think it would be great to have a contrib/ folder for bash scripts that can be invoked from the justfile.

@oleonardolima oleonardolima added this to the Wallet 2.2.0 milestone Sep 13, 2025
@oleonardolima
Copy link
Contributor

I'm not sure why, but now bdk_testenv is failing on my machine:

error: failed to parse manifest at `/var/folders/1j/b7q_zgx138q99356q8t83pjr0000gn/T/tmp.kb5jdzuAMK/.cargo/registry/src/index.crates.io-6f17d22bba15001f/base64ct-1.8.0/Cargo.toml`

Caused by:
  feature `edition2024` is required

  The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.83.0 (5ffbef321 2024-10-29)).
  Consider trying a newer version of Cargo (this may require the nightly release).
  See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2024 for more information about the status of this feature.
error: Recipe `verify-standalone` failed with exit code 101

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 3fbf406

It looks fine, the issue I was facing was exclusively on my machine.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 3fbf406

Works for rust stable, doesn't work for MSRV 1.63 or 1.75 but this is expected right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Non-coding related work
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

Add CI check to verify crates build correctly without workspace path deps
4 participants