Skip to content

fix(be): ttl to inc by #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2024
Merged

fix(be): ttl to inc by #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/redis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ class buildRedisStoreWithConfig implements RedisStore {
return await this.redisCache.multi().set(key, updateFunction(await this.get(key))).get(key).exec();
}

public async incrBy(key: string, incrementBy: number): Promise<number> {
public async incrBy(key: string, incrementBy: number, ttl?: Milliseconds): Promise<number> {
const ttlValue = this.getTtl(ttl);
await this.redisCache.set(key, 0, {PX: ttlValue, NX: true});
return await this.redisCache.incrBy(key, incrementBy);
}

Expand Down
6 changes: 3 additions & 3 deletions test/redis.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ describe('Redis Store', () => {

it('should increment a value', async () => {
const key = 'testKey';
const value = 1;

await redisClient.set(key, value);
const numberIncrBy = await redisClient.incrBy(key, 1);
const numberIncrBy = await redisClient.incrBy(key, 2);

const retrievedValue = await redisClient.get(key);
const ttl = await redisClient.ttl(key);
expect(ttl).to.not.equal(-1);
expect(numberIncrBy).toEqual(2);
expect(retrievedValue).toEqual(2);
});
Expand Down