Fix: Example App Builds #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Logger Initialization to Fix iOS Build Break in Example App
Description
Recent changes in the Expo Modules Core have updated the Logger API. The previous usage of Logger() without any parameters now fails because the initializer requires a logHandlers parameter. This change is causing iOS native builds to break.
the updated API here:
Logger.swift Source
I couldn't find it in the expo docs 🤷♂️
Changes
• Logger Initialization:
Updated all instances of Logger() to use Logger(logHandlers: []) to comply with the new API requirements.