Skip to content

Conversation

grafikrobot
Copy link
Member

@grafikrobot grafikrobot commented Jul 20, 2024

This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.

This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:

This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.

@grafikrobot grafikrobot marked this pull request as ready for review August 18, 2024 15:03
@grafikrobot
Copy link
Member Author

Please review and merge this PR at your earliest convenience.

@jzmaddock
Copy link
Collaborator

Hi @grafikrobot and thanks for this, two quick questions:

  1. Why the extra dependencies libs/static_assert libs/throw_exception libs/preprocessor when we really shouldn't have any pretty much.

  2. I see project requirements clause now has:

project
    : requirements
      <toolset>gcc:<cxxflags>-Wno-deprecated-declarations
      <library>/boost/core//boost_core
      <library>/boost/detail//boost_detail
      <library>/boost/type_traits//boost_type_traits
;

Again why the need?

I note that a similar clause in Boost.Math just recently completely broken our CI, so I removed it: boostorg/math#1254. I wondered where that had come from ;) Was this wrong?? The problem is it's a heavyweight dependency that makes every target in the Jamfile depend on the properties of those other libraries, rather than just the targets that actually need it.

Thanks!

@grafikrobot
Copy link
Member Author

  1. Why the extra dependencies libs/static_assert libs/throw_exception libs/preprocessor when we really shouldn't have any pretty much.

Because Boost.Core needs them. And the CI runs fail if they don't have those.

@jzmaddock
Copy link
Collaborator

Merged from parallel PR.

@jzmaddock jzmaddock closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants