Make fallback is_complete implementation more robust
#180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failures are not related to this PR. The CI config needs to be updated to remove the use of deprecated GHA features. |
|
Ping? |
|
Apologies, I'm trying to get CI working again, but see boostorg/boostdep#28 |
|
@Lastique can you merge latest develop into this so the CI can run now? Thanks! |
When all else fails, at least indicate the types that we always know to be incomplete: cv void and boundless arrays. Also cleanup formatting a bit.
Lastique
force-pushed
the
feature/better_fallback_is_complete
branch
from
d6f51a5 to
1456007
Compare
|
Done, CI has passed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all else fails, at least indicate the types that we always know to be incomplete: cv
voidand boundless arrays.Also cleanup formatting a bit and added tests.