feat(router): Fix after review and fixed Flow errors

Author: rafalmaksymiuk

src/elements/content-sidebar/SidebarPanels.js

@@ -102,7 +102,7 @@ const MARK_NAME_JS_LOADING_METADATA_REDESIGNED = `${ORIGIN_METADATA_SIDEBAR_REDE
 const MARK_NAME_JS_LOADING_DOCGEN = `${ORIGIN_DOCGEN_SIDEBAR}${BASE_EVENT_NAME}`;
 const MARK_NAME_JS_LOADING_VERSIONS = `${ORIGIN_VERSIONS_SIDEBAR}${BASE_EVENT_NAME}`;
 
-const URL_TO_FEED_ITEM_TYPE = { annotations: 'annotation', comments: 'comment', tasks: 'task' };
+const URL_TO_FEED_ITEM_TYPE = { annotations: 'annotation', comments: 'comment', tasks: 'task', versions: undefined };
 
 const LoadableDetailsSidebar = SidebarUtils.getAsyncSidebarContent(SIDEBAR_VIEW_DETAILS, MARK_NAME_JS_LOADING_DETAILS);
 const LoadableActivitySidebar = SidebarUtils.getAsyncSidebarContent(
@@ -527,7 +527,7 @@ class SidebarPanelsRouterDisabled extends React.Component<Props, State> {
         }
     }
 
-    isVersionsNavigationPath = (navigation: InternalSidebarNavigation) => {
+    isVersionsNavigationPath = (navigation?: InternalSidebarNavigation): boolean => {
         if (!navigation) {
             return false;
         }
@@ -632,7 +632,7 @@ class SidebarPanelsRouterDisabled extends React.Component<Props, State> {
 
         // Determine default sidebar using the same logic as the router version
         if (showDefaultPanel) {
-            return defaultPanel;
+            return defaultPanel || null;
         } if (canShowBoxAISidebarPanel && shouldBoxAIBeDefaultPanel) {
             return SIDEBAR_VIEW_BOXAI;
         } if (hasDocGen) {
@@ -724,7 +724,10 @@ class SidebarPanelsRouterDisabled extends React.Component<Props, State> {
 
         if (sidebarToRender) {
             if (sidebarToRender === SIDEBAR_VIEW_VERSIONS) {
-                this.handlePanelRender(internalSidebarNavigation?.sidebar);
+                const parentName = internalSidebarNavigation?.sidebar;
+                if (parentName) {
+                    this.handlePanelRender(parentName);
+                }
             } else {
                 this.handlePanelRender(sidebarToRender);
             }

src/elements/content-sidebar/__tests__/SidebarPanels.test.js

@@ -959,7 +959,7 @@ describe('elements/content-sidebar/SidebarPanels', () => {
                 ${{ sidebar: 'details', activeFeedEntryType: 'versions' }}                                                       | ${true}     | ${true}    | ${false}    | ${true}     | ${true}   | ${true}   | ${true}  | ${false}               | ${'boxai'}
                 ${{ sidebar: 'details', activeFeedEntryType: 'versions', versionId: '1234' }}                                    | ${true}     | ${true}    | ${false}    | ${true}     | ${true}   | ${true}   | ${true}  | ${false}               | ${'boxai'}
                 ${{ sidebar: 'metadata' }}                                                                                       | ${true}     | ${true}    | ${true}     | ${false}    | ${true}   | ${true}   | ${true}  | ${false}               | ${'boxai'}
-                ${{ sidebar: 'metadata', filteredTemplateIds: [1, 3] }}                                                          | ${true}     | ${true}    | ${true}     | ${false}    | ${true}   | ${true}   | ${true}  | ${false}               | ${'boxai'}
+                ${{ sidebar: 'metadata', filteredTemplateIds: ['1', '3'] }}                                                        | ${true}     | ${true}    | ${true}     | ${false}    | ${true}   | ${true}   | ${true}  | ${false}               | ${'boxai'}
                 ${{ sidebar: 'skills' }}                                                                                         | ${true}     | ${true}    | ${true}     | ${true}     | ${false}  | ${true}   | ${true}  | ${false}               | ${'boxai'}
                 ${{ sidebar: 'docgen' }}                                                                                         | ${true}     | ${true}    | ${true}     | ${true}     | ${true}   | ${false}  | ${true}  | ${false}               | ${'boxai'}
                 ${{ sidebar: 'boxai' }}                                                                                          | ${true}     | ${true}    | ${true}     | ${true}     | ${true}   | ${true}   | ${false} | ${false}               | ${'docgen'}
@@ -1104,12 +1104,12 @@ describe('elements/content-sidebar/SidebarPanels', () => {
                     renderSidebarPanelsRouterDisabled({
                         internalSidebarNavigation: {
                             sidebar: 'metadata',
-                            filteredTemplateIds: [123, 124],
+                            filteredTemplateIds: ['123', '124'],
                         },
                         features: { metadata: { redesign: { enabled: true } } },
                     });
                     const metadataSidebar = screen.getByTestId('metadata-sidebar-redesigned');
-                    expect(metadataSidebar).toHaveAttribute('data-filtered-template-ids', JSON.stringify([123, 124]));
+                    expect(metadataSidebar).toHaveAttribute('data-filtered-template-ids', JSON.stringify(['123', '124']));
                 });
 
                 test('should render redesigned sidebar if it is enabled', () => {