-
Notifications
You must be signed in to change notification settings - Fork 2k
Open
Labels
role: dev 🤖type: infrastructure 🤖Issues relating to devops, tech debt, etc.Issues relating to devops, tech debt, etc.
Milestone
Description
Through #20071 we turned on eslint for more files, which resulted in a lot of errors. The approach we landed on was to keep this enabled, and add eslint ignore comments to the codebase for the errors. These comments include this issue number so they can be used as a sort of checklist for errors to incrementally fix.
If you're interested in working on this, here's how you can help:
- Locally, search the entire codebase for the number of this issue.
- cmd+shift+f and search for:
carbon/issues/20452
- Look through the results and choose any file to fix
- Remove the eslint ignore comment, fix the problem
- Repeat this for <20 files so your PR is easier to review and get merged in
- Commit your changes - the pre-commit hook will run eslint too
- Open a PR and replace
➡️Closes 20452
Part of #20071
so that this issue is not closed
Important
Your PR should not contain "Closes #20452". This issue should remain open.
When there are no more comments in the codebase with carbon/issues/20452
, this issue can be closed.
Metadata
Metadata
Assignees
Labels
role: dev 🤖type: infrastructure 🤖Issues relating to devops, tech debt, etc.Issues relating to devops, tech debt, etc.
Type
Projects
Status
⏱ Backlog