Avoid deducing errors as argument instructions after subst #5710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If convert fails after applying a substitution in deduce, fail deduction rather than succeeding deduction with an ErrorInst in the deduced argument.
For example, in
toolchain/check/testdata/facet/fail_convert_class_type_to_generic_facet_value.carbon
theWrongGenericParam
is deduced for the first argument, then substituted into the second parameter, but the argument can not convert to the parameter after substitution. In this case, deduction fails instead of producig a call with an error in the second argument. The resulting semir drops the call with an error argument: