Skip to content

Fix a use of an imported InstId used where a local InstId is required #5998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

Fix a use of an imported InstId used where a local InstId is required #5998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion toolchain/check/import_ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,7 +1351,7 @@ static auto MakeAssociatedConstant(
.name_id = GetLocalNameId(context, import_assoc_const.name_id),
.parent_scope_id = SemIR::NameScopeId::None,
.decl_id = assoc_const_decl_id,
.generic_id = MakeIncompleteGeneric(context, import_assoc_const.decl_id,
.generic_id = MakeIncompleteGeneric(context, assoc_const_decl_id,
import_assoc_const.generic_id),
.default_value_id =
import_assoc_const.default_value_id.has_value()
Expand Down
10 changes: 0 additions & 10 deletions toolchain/check/testdata/for/actual.carbon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ fn Read() {
// CHECK:STDOUT: %IntRange.Make.type.51f: type = fn_type @IntRange.Make, @IntRange(%N.c80) [symbolic]
// CHECK:STDOUT: %IntRange.Make.2ec: %IntRange.Make.type.51f = struct_value () [symbolic]
// CHECK:STDOUT: %Iterate.type: type = facet_type <@Iterate> [concrete]
// CHECK:STDOUT: %Self.a96: %Iterate.type = bind_symbolic_name Self, 0 [symbolic]
// CHECK:STDOUT: %.Self.ef1: %Iterate.type = bind_symbolic_name .Self [symbolic_self]
// CHECK:STDOUT: %Iterate.assoc_type: type = assoc_entity_type @Iterate [concrete]
// CHECK:STDOUT: %assoc1.02e: %Iterate.assoc_type = assoc_entity element1, imports.%Core.import_ref.9e6 [concrete]
Expand Down Expand Up @@ -128,7 +127,6 @@ fn Read() {
// CHECK:STDOUT: %assoc0.8dc: %OrderedWith.assoc_type.d92 = assoc_entity element0, imports.%Core.import_ref.13d [symbolic]
// CHECK:STDOUT: %require_complete.0f5: <witness> = require_complete_type %ptr.784 [symbolic]
// CHECK:STDOUT: %Inc.type: type = facet_type <@Inc> [concrete]
// CHECK:STDOUT: %Iterate.facet.7f1: %Iterate.type = facet_value %.Self.as_type.935, (%Iterate.lookup_impl_witness.65a) [symbolic_self]
// CHECK:STDOUT: %assoc0.724: %Iterate.assoc_type = assoc_entity element0, imports.%Core.import_ref.4f9 [concrete]
// CHECK:STDOUT: %Iterate_where.type.fce: type = facet_type <@Iterate where %impl.elem1.164 = %Int.49d0e6.1 and %impl.elem0.19f = %Int.49d0e6.1> [symbolic]
// CHECK:STDOUT: %require_complete.d96: <witness> = require_complete_type %Iterate_where.type.fce [symbolic]
Expand Down Expand Up @@ -766,14 +764,6 @@ fn Read() {
// CHECK:STDOUT: %pattern_type.loc5_49 => constants.%pattern_type.dcd
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: specific @CursorType(constants.%Self.a96) {}
// CHECK:STDOUT:
// CHECK:STDOUT: specific @CursorType(constants.%Iterate.facet.7f1) {}
// CHECK:STDOUT:
// CHECK:STDOUT: specific @ElementType(constants.%Self.a96) {}
// CHECK:STDOUT:
// CHECK:STDOUT: specific @ElementType(constants.%Iterate.facet.7f1) {}
// CHECK:STDOUT:
// CHECK:STDOUT: specific @IntRange.as.Iterate.impl(constants.%N.c80) {
// CHECK:STDOUT: %N => constants.%N.c80
// CHECK:STDOUT: %IntRange => constants.%IntRange.349
Expand Down
Loading