fix(searcher): respect get-file-locations --server parameter (#155)
#155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 80.80% 80.75% -0.06%
==========================================
Files 12 12
Lines 719 717 -2
==========================================
- Hits 581 579 -2
Misses 138 138
🚀 New features to boost your workflow:
|
psaiz
reviewed
Jun 24, 2025
| new_server = server | ||
| elif searcher_protocol == "https": | ||
| new_server = SERVER_HTTPS_URI | ||
| new_server = server |
There was a problem hiding this comment.
this is the same as line 202, isn't it? Change the if condition to match both http and https?
…pendata#155) Fixes issue where `get-file-locations --server https://example.org` would ignore the custom server and revert to the default HTTPS server. Closes cernopendata#153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where
get-file-locations --server https://example.orgwould ignore the custom server and revert to the default HTTPS server.Closes #153