Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Conversation

codebender828
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes
    /start features)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Fixes: [ISSUE NUMBER]

What is the new behavior?

  • Allows focus trapping and scroll locking logic to be simplified.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022

🦋 Changeset detected

Latest commit: 8223433

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@chakra-ui/c-accordion Patch
@chakra-ui/c-alert Patch
@chakra-ui/c-breadcrumb Patch
@chakra-ui/c-button Patch
@chakra-ui/c-close-button Patch
@chakra-ui/c-code Patch
@chakra-ui/c-color-mode Patch
@chakra-ui/c-flex Patch
@chakra-ui/c-focus-lock Patch
@chakra-ui/c-form-control Patch
@chakra-ui/c-icon Patch
@chakra-ui/c-input Patch
@chakra-ui/c-modal Patch
@chakra-ui/c-motion Patch
@chakra-ui/c-popper Patch
@chakra-ui/c-portal Patch
@chakra-ui/c-reset Patch
@chakra-ui/c-scroll-lock Patch
@chakra-ui/c-spinner Patch
@chakra-ui/c-theme-provider Patch
@chakra-ui/c-visually-hidden Patch
@chakra-ui/vue-next Patch
@chakra-ui/vue-layout Patch
@chakra-ui/nuxt-next Patch
@chakra-ui/vue-system Patch
@chakra-ui/vue-test-utils Patch
@chakra-ui/vue-theme Patch
@chakra-ui/vue-theme-tools Patch
@chakra-ui/vue-utils Patch
@chakra-ui/vue-a11y Patch
@chakra-ui/vue-composables Patch
@chakra-ui/vue-auto-import Patch
@chakra-ui/vue-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@render
Copy link

render bot commented Feb 1, 2022

@vercel
Copy link

vercel bot commented Feb 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue-next – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue-next/A5AkDcPxrN1y7sLjdfNwY2PoenYP
✅ Preview: https://chakra-ui-vue-next-git-fix-modal-focus-lock-chakra-ui.vercel.app

chakra-ui-vue-next-playground – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue-next-playground/HDctCNyg1vjfB7HpnNhKjsApwq7D
✅ Preview: https://chakra-ui-vue-next-playground-git-fix-modal-fo-f27c74-chakra-ui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8223433:

Sandbox Source
Chakra UI Vue v1 Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Size Change: +4.1 kB (+5%) 🔍

Total Size: 83 kB

Filename Size Change
packages/c-focus-lock/dist/chakra-ui-c-focus-lock.cjs.prod.js 2.7 kB +570 B (+27%) 🚨
packages/c-input/dist/chakra-ui-c-input.cjs.prod.js 2.5 kB +27 B (+1%)
packages/c-modal/dist/chakra-ui-c-modal.cjs.prod.js 5.77 kB -537 B (-9%)
packages/c-portal/dist/chakra-ui-c-portal.cjs.prod.js 1.36 kB +34 B (+3%)
packages/theme/dist/chakra-ui-vue-theme.cjs.prod.js 13.1 kB +14 B (0%)
packages/utils/dist/chakra-ui-vue-utils.cjs.prod.js 4.96 kB +2.18 kB (+78%) 🆘
packages/vue-a11y/dist/chakra-ui-vue-a11y.cjs.prod.js 2.59 kB +1.44 kB (+125%) 🆘
packages/vue-composables/dist/chakra-ui-vue-composables.cjs.prod.js 3.4 kB +375 B (+12%) ⚠️
ℹ️ View Unchanged
Filename Size
packages/c-accordion/dist/chakra-ui-c-accordion.cjs.prod.js 483 B
packages/c-alert/dist/chakra-ui-c-alert.cjs.prod.js 1.34 kB
packages/c-breadcrumb/dist/chakra-ui-c-breadcrumb.cjs.prod.js 1.99 kB
packages/c-button/dist/chakra-ui-c-button.cjs.prod.js 2.31 kB
packages/c-close-button/dist/chakra-ui-c-close-button.cjs.prod.js 998 B
packages/c-code/dist/chakra-ui-c-code.cjs.prod.js 706 B
packages/c-color-mode/dist/chakra-ui-c-color-mode.cjs.prod.js 946 B
packages/c-flex/dist/chakra-ui-c-flex.cjs.prod.js 635 B
packages/c-form-control/dist/chakra-ui-c-form-control.cjs.prod.js 3.78 kB
packages/c-icon/dist/chakra-ui-c-icon.cjs.prod.js 955 B
packages/c-motion/dist/chakra-ui-c-motion.cjs.prod.js 3.03 kB
packages/c-popper/dist/chakra-ui-c-popper.cjs.prod.js 2.92 kB
packages/c-reset/dist/chakra-ui-c-reset.cjs.prod.js 1.42 kB
packages/c-scroll-lock/dist/chakra-ui-c-scroll-lock.cjs.prod.js 1.06 kB
packages/c-spinner/dist/chakra-ui-c-spinner.cjs.prod.js 937 B
packages/c-theme-provider/dist/chakra-ui-c-theme-provider.cjs.prod.js 385 B
packages/c-visually-hidden/dist/chakra-ui-c-visually-hidden.cjs.prod.js 471 B
packages/core/dist/chakra-ui-vue-next.cjs.prod.js 5.63 kB
packages/layout/dist/chakra-ui-vue-layout.cjs.prod.js 6.63 kB
packages/nuxt/dist/chakra-ui-nuxt-next.cjs.prod.js 435 B
packages/system/dist/chakra-ui-vue-system.cjs.prod.js 4.74 kB
packages/test-utils/dist/chakra-ui-vue-test-utils.cjs.prod.js 2.32 kB
packages/theme-tools/dist/chakra-ui-vue-theme-tools.cjs.prod.js 2.13 kB
tooling/auto-import/dist/chakra-ui-vue-auto-import.cjs.prod.js 436 B

compressed-size-action

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant