Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Conversation

codebender828
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes
    /start features)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The current version of @chakra-ui/styled-system@<=1.9.0 requires react as a dependency. See

Fixes: [ISSUE NUMBER]
#41

What is the new behavior?

  • This pull request, reserves the @chakra-ui/vue-utils package for only Vue.js related utilities, and consumes the other vanilla modules from @chakra-ui/utils@^1.5.0

Does this introduce a breaking change?

  • Yes
  • No

Other information

To be merged only when @chakra-ui/[email protected] and @chakra-ui/[email protected] are released.

@codebender828 codebender828 added dependencies Pull requests that update a dependency file ☄️ core team This issue/pull request has been opened by a Vue core team member labels Mar 27, 2021
@codebender828 codebender828 requested a review from a team March 27, 2021 09:10
@codebender828 codebender828 self-assigned this Mar 27, 2021
@vercel
Copy link

vercel bot commented Mar 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue-next – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue-next/HLd747KXTLMyytpqzUYHbC8JDu7Y
✅ Preview: https://chakra-ui-vue-next-git-refactor-use-core-utils-chakra-ui.vercel.app

chakra-ui-vue-next-playground – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue-next-playground/BB54eunCVZ7USeCJH9QA8fLLQ1mU
✅ Preview: https://chakra-ui-vue-git-refactor-use-core-utils-ch-3bf190.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2021

🦋 Changeset detected

Latest commit: 73acd07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@chakra-ui/c-accordion Patch
@chakra-ui/c-alert Patch
@chakra-ui/c-badge Patch
@chakra-ui/c-button Patch
@chakra-ui/c-color-mode Patch
@chakra-ui/c-flex Patch
@chakra-ui/c-icon Patch
@chakra-ui/c-popper Patch
@chakra-ui/c-portal Patch
@chakra-ui/c-reset Patch
@chakra-ui/c-spinner Patch
@chakra-ui/c-theme-provider Patch
@chakra-ui/c-visually-hidden Patch
@chakra-ui/vue-next Patch
@chakra-ui/nuxt-next Patch
@chakra-ui/vue-system Patch
@chakra-ui/vue-test-utils Patch
@chakra-ui/vue-theme Patch
@chakra-ui/vue-theme-tools Patch
@chakra-ui/vue-utils Patch
@chakra-ui/vue-auto-import Patch
@chakra-ui/vue-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codebender828

This comment has been minimized.

@codebender828
Copy link
Collaborator Author

codebender828 commented Mar 27, 2021

When chakra-ui/chakra-ui#3674 is merged, I'll mark this pull request as ready for review

@koca
Copy link
Contributor

koca commented Mar 29, 2021

@codebender828 great work, thanks 👍 i have some questions other than that LGTM :)

@codebender828 codebender828 marked this pull request as ready for review March 29, 2021 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
☄️ core team This issue/pull request has been opened by a Vue core team member dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants