fix(renderer): properly reset cursor position to start of line #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
requested review from
meowgorithm,
a team and
andreynering
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1472 +/- ##
=======================================
Coverage 69.04% 69.04%
=======================================
Files 17 17
Lines 1741 1741
=======================================
Hits 1202 1202
Misses 485 485
Partials 54 54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aymanbagabas
force-pushed
the
reset-cur-pos
branch
from
c83aec5 to
af342f2
Compare
This change uses carriage return (`\r`) instead of moving the cursor backward by the terminal width at the end of rendering in inline mode. With this, we don't need to know the terminal width to reset the cursor position, which avoids issues when the renderer doesn't yet know the terminal width (e.g. the first render where the size message hasn't been sent to the renderer yet). Fixes: #1471
aymanbagabas
force-pushed
the
reset-cur-pos
branch
from
af342f2 to
5ea5a34
Compare
caarlos0
approved these changes
Aug 16, 2025
andreynering
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses carriage return (
\r) instead of moving the cursor backward by the terminal width at the end of rendering in inline mode. With this, we don't need to know the terminal width to reset the cursor position, which avoids issues when the renderer doesn't yet know the terminal width (e.g. the first render where the size message hasn't been sent to the renderer yet).Fixes: #1471