fix: send commands in a goroutine without executing them immediately #1473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
requested review from
a team and
kujtimiihoxha
and removed request for
a team
The commands channel handler handles commands and their execution. We should not execute them ourself in the event loop and instead send them to the commands channel where the handles will take care of executing them. Fixes: f5da8d0 (fix: handle nested SequenceMsg in event loop and use sync.WaitGroup f… (#1463))
caarlos0
approved these changes
Aug 16, 2025
Comment on lines
-508
to
-510
| if cmd == nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
were these checks needed? if so, might want to add them to sendCmd
andreynering
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commands channel handler handles commands and their execution. We should not execute them ourselves in the event loop and instead send them to the commands channel where the handles will take care of executing them.
Fixes: f5da8d0 (fix: handle nested SequenceMsg in event loop and use sync.WaitGroup f… (#1463))