.github/workflows: use Ruby provided by runners

In PR git-lfs#3840 we introduced a GitHub Actions workflow to build our
release assets when we push a new version tag.  As a final step in this
workflow we run our script/packagecloud.rb script, which requires the
use of the "packagecloud-ruby" Ruby gem.  At the time, these
requirements meant we needed to first execute the actions/setup-ruby
action so we could then install the gem and run our Ruby script.

Later, in PR git-lfs#4230, we added steps to our CI workflow to build our
manual pages, and since these required the use of the "ronn" Ruby gem,
we also added the actions/setup-ruby action to our CI workflow.
(We subsequently migrated our manual page source files to the AsciiDoc
format, in PR git-lfs#5054, but we continue to use Ruby and the "asciidoctor"
gem to build our manual pages.)

Then in commit b7fa3a5 of PR git-lfs#5236 we
upgraded both of our Actions workflows to use the ruby/setup-ruby
action instead of the now-deprecated actions/setup-ruby one.  Because
the ruby/setup-ruby action installs the MSYS2 environment on Windows
and sets several key environment variables like PATH and TMPDIR, we
also introduced steps to make sure our CI and release processes
continued to work as expected in this context, by clearing the
TMPDIR variable and renaming the directory containing the MSYS2
executables.

Fortunately, the default runners provided by GitHub Actions for the
macOS, Windows, and Ubuntu Linux platforms are now all provisioned with
an installation of Ruby 3.x which includes the "gem" utility we need to
install the "asciidoctor" and "packagecloud-ruby" gems.  As these are
all we require to run our Ruby scripts, we no longer need the more
extensive Ruby development environment provided by the ruby/setup-ruby
action.

We can therefore simply remove the ruby/setup-ruby steps from our
workflows, along with all the special handling of the MSYS2 environment
and the TMPDIR environment variable on Windows.

Author: chrisd8088

.github/workflows/ci.yml

@@ -21,8 +21,7 @@ jobs:
       # annotated tags into lightweight ones, breaking "git describe".
       # See https://github.com/actions/checkout/issues/290 and
       # https://github.com/actions/checkout/issues/882 for details.
-    - uses: ruby/setup-ruby@v1
-    - run: gem install asciidoctor
+    - run: sudo gem install asciidoctor
     - uses: actions/setup-go@v5
       with:
         go-version: ${{ matrix.go }}
@@ -67,11 +66,7 @@ jobs:
         fetch-depth: 0
         persist-credentials: false
         ref: ${{ github.ref }}
-    - uses: ruby/setup-ruby@v1
     - run: gem install asciidoctor
-    - run: Rename-Item -Path C:\msys64 -NewName msys64-tmp -Force
-      # We move the MSYS2 installed for Ruby aside to prevent use of its Git,
-      # which does not honour the PATH we set to our built git-lfs binary.
     - uses: actions/setup-go@v5
       with:
         go-version: '1.23.x'
@@ -88,10 +83,8 @@ jobs:
         flavor: minimal
       # We install the SDK so as to have access to the msgfmt.exe binary
       # from the GNU gettext package.
-    - run: GOPATH="$HOME/go" PATH="$HOME/go/bin:$PATH" env -u TMPDIR script/cibuild
+    - run: GOPATH="$HOME/go" PATH="$HOME/go/bin:$PATH" script/cibuild
       shell: bash
-      # We clear the TMPDIR set for Ruby so mktemp and Go use the same
-      # volume for temporary files.
     - run: rm -f commands/mancontent_gen.go
       shell: bash
     - run: GOPATH="$HOME/go" PATH="$HOME/go/bin:$PATH" make GOARCH=386 -B

.github/workflows/release.yml

@@ -23,11 +23,7 @@ jobs:
       # annotated tags into lightweight ones, breaking "git describe".
       # See https://github.com/actions/checkout/issues/290 and
       # https://github.com/actions/checkout/issues/882 for details.
-    - uses: ruby/setup-ruby@v1
     - run: gem install asciidoctor
-    - run: Rename-Item -Path C:\msys64 -NewName msys64-tmp -Force
-      # We move the MSYS2 installed for Ruby aside to prevent use of its Git,
-      # which does not honour the PATH we set to our built git-lfs binary.
     - uses: actions/setup-go@v5
       with:
         go-version: ${{ matrix.go }}
@@ -46,21 +42,19 @@ jobs:
       # from the GNU gettext package.
     - run: mkdir -p bin/releases
       shell: bash
-      # We clear the TMPDIR set for Ruby so mktemp and Go use the same
-      # volume for temporary files.
-    - run: PATH="$HOME/go/bin:$PATH" GOARCH=amd64 go generate && env -u TMPDIR make bin/releases/git-lfs-windows-amd64-$(git describe).zip
+    - run: PATH="$HOME/go/bin:$PATH" GOARCH=amd64 go generate && make bin/releases/git-lfs-windows-amd64-$(git describe).zip
       shell: bash
       env:
         FORCE_LOCALIZE: true
-    - run: PATH="$HOME/go/bin:$PATH" GOARCH=386 go generate && env -u TMPDIR make bin/releases/git-lfs-windows-386-$(git describe).zip
+    - run: PATH="$HOME/go/bin:$PATH" GOARCH=386 go generate && make bin/releases/git-lfs-windows-386-$(git describe).zip
       shell: bash
       env:
         FORCE_LOCALIZE: true
-    - run: PATH="$HOME/go/bin:$PATH" GOARCH=arm64 go generate && env -u TMPDIR make bin/releases/git-lfs-windows-arm64-$(git describe).zip
+    - run: PATH="$HOME/go/bin:$PATH" GOARCH=arm64 go generate && make bin/releases/git-lfs-windows-arm64-$(git describe).zip
       shell: bash
       env:
         FORCE_LOCALIZE: true
-    - run: env -u TMPDIR make release-windows-stage-1
+    - run: make release-windows-stage-1
       shell: bash
       env:
         FORCE_LOCALIZE: true
@@ -77,7 +71,7 @@ jobs:
         file-digest: SHA256
         timestamp-rfc3161: http://timestamp.acs.microsoft.com
         timestamp-digest: SHA256
-    - run: env -u TMPDIR make release-windows-stage-2
+    - run: make release-windows-stage-2
       shell: bash
     - uses: azure/[email protected]
       with:
@@ -92,9 +86,9 @@ jobs:
         file-digest: SHA256
         timestamp-rfc3161: http://timestamp.acs.microsoft.com
         timestamp-digest: SHA256
-    - run: env -u TMPDIR make release-windows-stage-3
+    - run: make release-windows-stage-3
       shell: bash
-    - run: env -u TMPDIR make release-windows-rebuild
+    - run: make release-windows-rebuild
       shell: bash
     - uses: actions/upload-artifact@v4
       with:
@@ -113,7 +107,6 @@ jobs:
         fetch-depth: 0
         persist-credentials: false
         ref: ${{ github.ref }}
-    - uses: ruby/setup-ruby@v1
     - run: gem install asciidoctor
     - uses: actions/setup-go@v5
       with:
@@ -151,8 +144,7 @@ jobs:
         fetch-depth: 0
         persist-credentials: false
         ref: ${{ github.ref }}
-    - uses: ruby/setup-ruby@v1
-    - run: gem install asciidoctor
+    - run: sudo gem install asciidoctor
     - uses: actions/setup-go@v5
       with:
         go-version: ${{ matrix.go }}
@@ -188,8 +180,7 @@ jobs:
         fetch-depth: 0
         persist-credentials: false
         ref: ${{ github.ref }}
-    - uses: ruby/setup-ruby@v1
-    - run: gem install packagecloud-ruby
+    - run: sudo gem install packagecloud-ruby
     - run: git clone https://github.com/git-lfs/build-dockers.git "$HOME/build-dockers"
     - run: (cd "$HOME/build-dockers" && ./build_dockers.bsh)
     - run: ./docker/run_dockers.bsh --prune
@@ -206,8 +197,7 @@ jobs:
         fetch-depth: 0
         persist-credentials: false
         ref: ${{ github.ref }}
-    - uses: ruby/setup-ruby@v1
-    - run: gem install packagecloud-ruby
+    - run: sudo gem install packagecloud-ruby
     - run: git clone https://github.com/git-lfs/build-dockers.git "$HOME/build-dockers"
     - run: (cd "$HOME/build-dockers" && ./build_dockers.bsh --arch=arm64 debian_11 debian_12)
     - run: ./docker/run_dockers.bsh --prune --arch=arm64 debian_11 debian_12