fix: multiply the embedding list by their dimension to get the real size #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current is not working, I got the error:
self._index.add_items(data=embeddings, ids=ids, num_threads=self.config.num_threads)
RuntimeError: The number of elements exceeds the specified limit
We need to multiply each element of the embedding list by their side (which is constant: self.embedding_dim) in the line 56 :
if self.size + len(embeddings)*self.embedding_dim >= self.max_size: