Fix most of the build #3165
Merged
Fix most of the build #3165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
force-pushed
the
fix-build-march-5
branch
3 times, most recently
from
e4d57bd to
e6fa601
Compare
vemv
commented
Mar 5, 2022
| @@ -210,6 +210,7 @@ | |||
| (before-each | |||
| ;; FIXME: Needed because its set in an earlier test | |||
| (setq-local cider-jack-in-lein-plugins nil) | |||
| (setq-local cider-jack-in-dependencies nil) | |||
There was a problem hiding this comment.
Similar to the ones above per Needed because its set in an earlier test
|
Iterated a few times until the build was not only green but it also made sense :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linting and tests but not
cider-util.el:377:8:Error: value returned from (fboundp 'package-get-version) is unused(https://app.circleci.com/pipelines/github/clojure-emacs/cider/1157/workflows/80e0b8e4-6f6d-4497-81a6-5268ffac52a1/jobs/5337)