Skip to content

minor refactoring of AudioEngine #19655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2019
Merged

minor refactoring of AudioEngine #19655

merged 1 commit into from
May 6, 2019

Conversation

JohnCoconut
Copy link
Contributor

  • emplace_back accept constructor args directly
  • use reserve
  • remove superfluous null pointer check
  • add null pointer check around task()

@JohnCoconut
minor refactoring of AudioEngine
a39f393 
* emplace_back accept constructor args directly
* use reserve

* remove superfluous null pointer check

* add null pointer check
@minggo minggo added this to the next milestone May 5, 2019
@minggo minggo merged commit 8fb45be into cocos2d:v3 May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggo minggo minggo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnCoconut @minggo