Skip to content

Sprite and RenderTexture blending mode set based off texture premultiplied alpha setting #20154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 24, 2019
Merged

Sprite and RenderTexture blending mode set based off texture premultiplied alpha setting #20154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
30fb96e
Merge pull request #4 from cocos2d/v3
rh101 May 29, 2019
67d2f79
Added RenderTexture::saveToFileAsNonPMA() to save images without PMA.
rh101 May 30, 2019
b5bdada
[CCImage-ios.mm] Fixed indentation.
rh101 Jun 4, 2019
7065335
Merge pull request #5 from cocos2d/v3
rh101 Jun 16, 2019
94ec877
Merge pull request #7 from cocos2d/v3
rh101 Jun 22, 2019
92dd2e5
Merge pull request #8 from cocos2d/v3
rh101 Jun 30, 2019
628c758
Merge pull request #9 from cocos2d/v3
rh101 Jul 20, 2019
df5ef30
Merge pull request #10 from cocos2d/v3
rh101 Jul 26, 2019
03c7479
Merge pull request #11 from cocos2d/v3
rh101 Sep 20, 2019
ffc7cc7
Merge pull request #13 from cocos2d/v3
rh101 Sep 23, 2019
f0256b3
[CCSprite.cpp] Sprite:initWithTexture() should set the blend mode dep…
rh101 Sep 23, 2019
0edf68f
Fix for incorrect _opacityModifyRGB on non-PMA.
rh101 Sep 23, 2019
4cf743c
[CCSprite.cpp] Removed redundant code related to blending mode and op…
rh101 Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cocos/2d/CCRenderTexture.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,10 +305,11 @@ bool RenderTexture::initWithWidthAndHeight(int w, int h, Texture2D::PixelFormat

#if CC_ENABLE_PREMULTIPLIED_ALPHA != 0
_sprite->setBlendFunc(BlendFunc::ALPHA_PREMULTIPLIED);
_sprite->setOpacityModifyRGB(true);
#else
_sprite->setBlendFunc(BlendFunc::ALPHA_NON_PREMULTIPLIED);
_sprite->setOpacityModifyRGB(false);
#endif
_sprite->setOpacityModifyRGB(true);

glBindRenderbuffer(GL_RENDERBUFFER, oldRBO);
glBindFramebuffer(GL_FRAMEBUFFER, _oldFBO);
Expand Down
4 changes: 0 additions & 4 deletions cocos/2d/CCSprite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,6 @@ bool Sprite::initWithTexture(Texture2D *texture, const Rect& rect, bool rotated)
_recursiveDirty = false;
setDirty(false);

_opacityModifyRGB = true;

_blendFunc = BlendFunc::ALPHA_PREMULTIPLIED;

_flippedX = _flippedY = false;

// default transform anchor: center
Expand Down