Skip to content

manually maintain reference count (#20329) #20337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2019
Merged

manually maintain reference count (#20329) #20337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cocos/ui/UIVideoPlayer-ios.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ typedef NS_ENUM(NSInteger, PlayerbackState) {
PlayerbackStateCompleted
};

@property (strong, nonatomic) AVPlayerViewController * playerController;
@property (assign, nonatomic) AVPlayerViewController * playerController;

- (void) setFrame:(int) left :(int) top :(int) width :(int) height;
- (void) setURL:(int) videoSource :(std::string&) videoUrl;
Expand Down Expand Up @@ -87,7 +87,7 @@ @implementation UIVideoViewWrapperIos
-(id)init:(void*)videoPlayer
{
if (self = [super init]) {
self.playerController = [[AVPlayerViewController new] autorelease];
self.playerController = [AVPlayerViewController new];

[self setRepeatEnabled:FALSE];
[self showPlaybackControls:TRUE];
Expand Down