Skip to content

Gallery Mobile Styling + CSS Cleanup #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2021
Merged

Gallery Mobile Styling + CSS Cleanup #1111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1058f5f
attempt 1 at cliping images
sjmiller7 Jan 21, 2021
1b5518e
Merge branch 'bh-1026' into bh-1084
sjmiller7 Jan 22, 2021
41a332c
mobile gallery + css cleanup
sjmiller7 Jan 22, 2021
f9ae394
fixes
sjmiller7 Jan 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions gallery.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,16 @@ <h1>BrickHack 6</h1>
<p>February 8-9 2020</p>
<p>40 schools - 590 hackers - 24 hours</p>
</div>
<div class="images">
<img class="image" src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img class="image" src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img class="image" src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img class="image" src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img class="image" src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img class="image" src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img class="image" src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img class="image" src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img class="image" src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<div class="image-container">
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
</div>
<!-- BH5 -->
<div class="header">
Expand All @@ -71,16 +71,16 @@ <h1>BrickHack 5</h1>
<p>February 8-9 2019 idk</p>
<p>this is filler</p>
</div>
<div class="images">
<img src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<img src="https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80" alt="image"/>
<div class="image-container">
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
<div class="image"></div>
</div>
<!-- This is where Parcel imports are located! (SASS, etc.) -->
<script src="./gallery.js"></script>
Expand Down
84 changes: 61 additions & 23 deletions sass/gallery.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,44 @@
// Variables
$orange: #F98728;
$off-white: #F9F6F3;

* {
padding: 0;
margin: 0;
box-sizing: border-box;
}

body {
background-color: #F9F6F3;
background-color: $off-white;
}

nav {
position: fixed;
top: 0;
width: 100%;
background-color: #F9F6F3;
border-bottom: 3px solid #F98728;
background-color: $off-white;
border-bottom: 3px solid $orange;
display: flex;
justify-content: space-between;
padding: 0px 20px;
z-index: 1;

a {
color: #F98728;
color: $orange;
font-family: Roboto, sans-serif;
text-decoration: none;
font-size: 25px;
margin: 10px;
border-bottom: 3px solid rgba(#F98728, 0%);
border-bottom: 3px solid rgba($orange, 0%);
border-top: 3px solid transparent; // for balance

&:hover, &:active {
border-bottom: 3px solid rgba(#F98728, 100%);
border-bottom: 3px solid rgba($orange, 100%);
}
}

i {
color: #F98728;
color: $orange;
font-size: 35px;
margin: 10px;
}
Expand All @@ -58,7 +62,7 @@ nav {
}

.header {
background-color: #F98728;
background-color: $orange;
width: 100%;
padding: 30px;
}
Expand All @@ -69,7 +73,7 @@ nav {

h1, p {
text-align: center;
color: white;
color: $off-white;
font-family: Roboto, sans-serif;
}

Expand All @@ -87,27 +91,29 @@ p {
margin: auto;
width: 100px;
height: 100px;
background: #F9F6F3;
background: $off-white;
border-radius: 25px;
}

.images {
.image-container {
display: grid;
grid-template-columns: repeat(3, 1fr);
grid-template-columns: repeat(5, 1fr);
gap: 20px;
padding: 20px;
justify-items: stretch;
justify-content: center;
}
align-items: center;

.images img {
width: 100%;
height: 285px;
cursor: pointer;
.image {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.image seems like its the image itself; maybe .image-container?

cursor: pointer;
width: 100%;
height: 40vh;
background-size: cover;
background-position: center center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the Joy of background images I really like this implementation 😄

background-image: url(https://images.unsplash.com/photo-1532630571098-79a3d222b00d?ixlib=rb-1.2.1&ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&auto=format&fit=crop&w=2938&q=80);
}
}

#modal-background {
background-color: #000000dd;
background-color: rgba(black, 85%);
width: 100%;
height: 100%;
position: fixed;
Expand All @@ -119,7 +125,7 @@ p {

#modal {
text-align: center;
background-color: #F9F6F3;
background-color: $off-white;
border-radius: 20px;
padding: 20px;
top: 10%;
Expand All @@ -133,7 +139,7 @@ p {
display: none;

i {
color: #F98728;
color: $orange;
font-size: 40px;
}

Expand Down Expand Up @@ -167,6 +173,24 @@ p {
justify-content: space-between;
}

@media screen and (max-width: 1800px) {
.images {
grid-template-columns: repeat(4, 1fr);
}
}

@media screen and (max-width: 1400px) {
.images {
grid-template-columns: repeat(3, 1fr);
}
}

@media screen and (max-width: 1000px) {
.images {
grid-template-columns: repeat(2, 1fr);
}
}

@media screen and (max-width: 660px) {
#mobile-menu {
display: flex;
Expand All @@ -184,11 +208,25 @@ p {
flex-direction: column;
align-items: center;
display: none;
border-top: 3px solid #F98728ff;
border-top: 3px solid $orange;
width: 100%;
}

.show-menu {
display: flex;
}

.images {
grid-template-columns: repeat(1, 1fr);
}

#modal {
width: 80%;
max-height: none;

img {
width: 100%;
max-height: none;
}
}
}