Move to Netlify for staging+PRs! Remove staging GHA script + peek.yml #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Netlify for staging PRs
|
✔️ Deploy Preview for infallible-lumiere-e9d357 ready! 🔨 Explore the source changes: 5986c96 🔍 Inspect the deploy log: https://app.netlify.com/sites/infallible-lumiere-e9d357/deploys/60d4f8e5ecf14e0007edc1d3 😎 Browse the preview: https://deploy-preview-1202--infallible-lumiere-e9d357.netlify.app |
peterkos
requested review from
a team and
cbaudouinjr
and removed request for
a team
peterkos
changed the title
peterkos
changed the title
cbaudouinjr
approved these changes
Jun 26, 2021
peterkos
added a commit
that referenced
this pull request
Jul 3, 2021
* Fix scaling and responsiveness, Safari bug (#1196) * Setup structure for post event * Start of designs * Gif added * Fix the thing * Sizing * last things * Fix scaling issues on desktop and safari * Fix a lot of responsive * BH8 windows87 prereg style website * Rename old site event.html -> bh7.html * Rename css correctly * Remove commented out styling * Style fixes and alt tags; fix gap issue on safari * Move to Netlify for staging+PRs! Remove staging GHA script + peek.yml (#1202) * Remove staging GHA script + peek.yml Using Netlify for staging PRs * Empty * Only run build on prod push, not on develop * Empty * Convert SCSS->CSS vars for mobile styling * Many responsive tweaks Notable is the height constraint added tot he media query, and width->max-width to allow for better mobile resizing * Tweak window again Normally i'd use a % but window glitches when too small and imo cutoff is better * PR feedback * Comments and alt tags * gifs are local fiels now instead of hotlinked * Mobile fixes and scaling * Fix social card and remove unused font * Update sass/index.scss Co-authored-by: Claire Gallup <[email protected]> * Update sass/index.scss Co-authored-by: Claire Gallup <[email protected]> * Update sass/index.scss Co-authored-by: Claire Gallup <[email protected]> * Update sass/index.scss Co-authored-by: Claire Gallup <[email protected]> * Update sass/index.scss Co-authored-by: Claire Gallup <[email protected]> * Fix sponsor email * BH8 Preregistration: Window easter egg (#1203) * Moving window! * Update browserlist cache * Fix footer dispapearing on mobile * Fix unused code move to todo * newline EOF * Update index.js Co-authored-by: Claire Gallup <[email protected]> * Update index.js Co-authored-by: Claire Gallup <[email protected]> * De semicolonification, fix out of range bug Co-authored-by: Claire Gallup <[email protected]> * Add Mailchimp submit form (#1204) * Altered Mailchimp code * bh rit -> BrickHack Interest audience Co-authored-by: Claire Gallup <[email protected]> Co-authored-by: Chris Baudouin, Jr <[email protected]>
peterkos
added a commit
that referenced
this pull request
Aug 4, 2021
…#1202) * Remove staging GHA script + peek.yml Using Netlify for staging PRs * Empty * Only run build on prod push, not on develop * Empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Implements #1199
Using Netlify for PRs into
developinstead of FeaturePeek +build.Staging shouuuld be available at staging.brickhack.io but its gonna take a day or so to propogate the DNS.
buildstep is only run on master branch now, as we don't use Netlify for prod builds (since we just build on GHA and deploy to GitHub Pages).Netlify Config
The login for Netlify is in the Vault.