Skip to content

Conversation

sjmiller7
Copy link
Contributor

Fixes #1212

All links still need the correct sources added/verified, and the sections will still need backgrounds added. For now, I am going to leave those to do in the final touch ups of issue #1206

@sjmiller7 sjmiller7 added the bh club brickhack club site label Jul 27, 2021
@sjmiller7 sjmiller7 requested a review from peterkos July 27, 2021 02:13
@sjmiller7 sjmiller7 self-assigned this Jul 27, 2021
@sjmiller7 sjmiller7 linked an issue Jul 27, 2021 that may be closed by this pull request
Copy link

@skyegallup skyegallup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but otherwise looks alright

bhclub.html Outdated
</div>
<div>
<a class="social-link" href="https://discord.gg/gNJXjvzkuB" target="_blank">Discord</a>
<a class="social-link" href="#" target="_blank">CampusGroups</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Michael said in the BrickHack server that we don't need to include a CampusGroups link if you don't want to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point I'm leaving decision of what links are actually included for the final pr (#1206), since we have about five different lists and I've already got a ton of merge conflicts with this and the about pr

@netlify
Copy link

netlify bot commented Jul 31, 2021

✔️ Deploy Preview for infallible-lumiere-e9d357 ready!

🔨 Explore the source changes: 162758f

🔍 Inspect the deploy log: https://app.netlify.com/sites/infallible-lumiere-e9d357/deploys/611b0b101705e60008743a98

😎 Browse the preview: https://deploy-preview-1214--infallible-lumiere-e9d357.netlify.app/bhclub

@sjmiller7 sjmiller7 requested a review from skyegallup July 31, 2021 02:02
Copy link
Contributor

@peterkos peterkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs mobile fixing

@sjmiller7 sjmiller7 requested a review from peterkos August 17, 2021 00:54
Copy link
Contributor

@peterkos peterkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2021-08-16 at 20 58 09
Corner radius issue

@sjmiller7 sjmiller7 requested a review from peterkos August 17, 2021 01:04
@sjmiller7 sjmiller7 merged commit f95f679 into bh-1206 Aug 17, 2021
@sjmiller7 sjmiller7 deleted the bh-1212 branch August 17, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bh club brickhack club site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Section - BrickHack Club Site
3 participants