-
Notifications
You must be signed in to change notification settings - Fork 30
Contact Section - BrickHack Club Site #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, but otherwise looks alright
bhclub.html
Outdated
</div> | ||
<div> | ||
<a class="social-link" href="https://discord.gg/gNJXjvzkuB" target="_blank">Discord</a> | ||
<a class="social-link" href="#" target="_blank">CampusGroups</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Michael said in the BrickHack server that we don't need to include a CampusGroups link if you don't want to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point I'm leaving decision of what links are actually included for the final pr (#1206), since we have about five different lists and I've already got a ton of merge conflicts with this and the about pr
✔️ Deploy Preview for infallible-lumiere-e9d357 ready! 🔨 Explore the source changes: 162758f 🔍 Inspect the deploy log: https://app.netlify.com/sites/infallible-lumiere-e9d357/deploys/611b0b101705e60008743a98 😎 Browse the preview: https://deploy-preview-1214--infallible-lumiere-e9d357.netlify.app/bhclub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just needs mobile fixing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #1212
All links still need the correct sources added/verified, and the sections will still need backgrounds added. For now, I am going to leave those to do in the final touch ups of issue #1206