Skip to content

do the thing #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
+10 −1
Closed

do the thing #9

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce87061
do the thing
thomasrockhu-codecov Sep 13, 2025
765520e
fix: add fetch-depth
thomasrockhu-codecov Sep 13, 2025
d0e41bb
fix: fail
thomasrockhu-codecov Sep 13, 2025
84730ab
fix: try one more time
thomasrockhu-codecov Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/test_calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import random

from .calculator import Calculator


Expand All @@ -24,6 +26,8 @@ def test_multiply():
assert Calculator.multiply(-4, 2.0) == -8.0

def test_divide():
if random.random() < 0.2:
assert True == False
Comment on lines +32 to +33
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The test test_divide will fail non-deterministically approximately 20% of the time due to a random assertion failure, causing CI/CD pipelines to fail unpredictably.

  • Description: The test_divide function includes a conditional statement if random.random() &lt; 0.2: assert True == False. This introduces a non-deterministic failure, causing the test to fail approximately 20% of the time it is run. Since the CI/CD pipeline executes tests on every push and pull request, this will lead to random pipeline failures. These failures will block pull requests and deployments unpredictably, requiring developers to re-run jobs or investigate spurious failures, which erodes confidence in the test suite.

  • Suggested fix: Remove the conditional block that causes the random assertion failure: if random.random() &lt; 0.2: assert True == False. Tests should be deterministic to ensure reliable and repeatable results.
    severity: 0.75, confidence: 1.0

Did we get this right? 👍 / 👎 to inform future reviews.

# assert Calculator.divide(1, 2) == 0.5
assert Calculator.divide(1.0, 2.0) == 0.5
assert Calculator.divide(0, 2.0) == 0
Expand Down