Merge Structured Data branch into master

[nicolas-raoul]

1. Clone this repository somewhere on your computer: https://github.com/VitalyVPinchuk/apps-android-commons/tree/upload_caption_depict
2. Switch to the upload_caption_depict branch
3. Test it: Browse by items, see parent and child items
4. Test it more: Upload a picture via Nearby and post below the URL of the uploaded picture
5. Merge the latest master of git@github.com:commons-app/apps-android-commons.git
6. Fix the conflicts
7. Test again (steps 3 and 4)
8. Let us know when you are done by posting a comment below

[GearGit]

1. Clone this repository somewhere on your computer: https://github.com/VitalyVPinchuk/apps-android-commons/tree/upload_caption_depict
2. Switch to the upload_caption_depict branch
3. Test it: Browse by items, see parent and child items
4. Test it more: Upload a picture via Nearby and post below the URL of the uploaded picture
5. Merge the latest master of git@github.com:commons-app/apps-android-commons.git
6. Fix the conflicts
7. Test again (steps 3 and 4)
8. Send pull request to git@github.com:commons-app/apps-android-commons.git

Can I work on this issue?

[nicolas-raoul]

@GearGit : Yes, thanks! Please let us know about your progress at least once per day :-)

[GearGit]

@GearGit : Yes, thanks! Please let us know about your progress at least once per day :-)

I will surely update my progress daily, as a matter of fact, I have already started working on it.

[GearGit]

@nicolas-raoul Can I use Travis CI for merging conflicts?

[nicolas-raoul]

Not sure how it might help, but feel free to try.

…

On Tue, 26 Nov 2019, 13:33 Somanshu, ***@***.***> wrote: @nicolas-raoul <https://github.com/nicolas-raoul> Can I use Travis CI for merging conflicts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3222?email_source=notifications&email_token=AAAYKBWCFV22ZHXRTFHWZ7DQVSRIVA5CNFSM4JRCNLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEVTHI#issuecomment-558455197>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYKBTMX7JTJTGNSRYYZNTQVSRIVANCNFSM4JRCNLAA> .

[maskaravivek]

I am not sure if its a beginner-friendly issue. Apart from resolving the merge conflicts, this task would also require fixing the Wikidata API calls. None of the authenticated API were working earlier.

[nicolas-raoul]

Vivek, thanks for the insight! I think the merging is newcomer-friendly. Then URLs can be replaced by an expert 🙂

…

On Tue, 26 Nov 2019, 13:51 Vivek Maskara, ***@***.***> wrote: I am not sure if its a beginner-friendly issue. Apart from resolving the merge conflicts, this task would also require fixing the Wikidata API calls. None of the authenticated API were working earlier. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3222?email_source=notifications&email_token=AAAYKBX36CAOCRRSKSAERDLQVSTONA5CNFSM4JRCNLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEWQ6A#issuecomment-558459000>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYKBWQFXJNZHBRSCNV4JDQVSTONANCNFSM4JRCNLAA> .

[maskaravivek]

I think the merging is newcomer-friendly.

Are we talking about merging master into the structured-data branch? If yes, then it should be fine that anyone picks it. :)

Else, if we are talking about merging structured-data into master then everything will need to work perfectly before it can be merged.

Then URLs can be replaced by an expert 🙂

Also, the URLs are correct AFAIK, but some changes need to be done in how the edit token is fetched. Also, some of the APIs need to be modified to send multipart request params instead of application/x-www-form-urlencoded.

[nicolas-raoul]

Are we talking about merging master into the structured-data branch?

Yes, that is an important task to ensure it stays up-to-date.

Else, if we are talking about merging structured-data into master then everything will need to work perfectly before it can be merged.
Also, the URLs are correct AFAIK, but some changes need to be done in how the edit token is fetched. Also, some of the APIs need to be modified to send multipart request params instead of application/x-www-form-urlencoded.

Is there an issue about this? If not it would be great to create one, so that we don't forget some todo or tips :-)

[maskaravivek]

Yes, that is an important task to ensure it stays up-to-date.

Do you mind updating the task title and description?

Is there an issue about this? If not it would be great to create one, so that we don't forget some todo or tips :-)

Sure, will do. :)

[nicolas-raoul]

Fixed, thanks! :-)