Dialog buttons set as opposite to Android design conventions

[aryan-earth]

Summary:
The text of positive and negative buttons of the dialogs in DialogUtils has been set as the opposite and should we swapped. The positive button text is set as "No" and the negative button text is set as "Yes" as evident in the image attached below.

Side notes:
This issue was created from a discussion that happened at #3397. The relevant discussion starts from #3397 (comment). This was created to discuss the rationale behind why the buttons are the way they are now, if there are any reasons.

Device and Android version:
Redmi Note 5 Pro & Android 9

Commons app version:
2.12.3-debug-testing~65592539b

Screen-shots:

Current state

Should be like the image below:

Would you like to work on the issue?

Sure. Although, if a new volunteer wants to get their hands dirty in the commons code, this could be a great opportunity for them. This could be marked as a Good First Issue.

[madhurgupta10]

@glitch101 I am not sure about the design convention but I think you are right, even in Gmail or Android Settings the convention seems to place the Cancel on the Left and OK on Right.

@sivaraam What do you think?

[sivaraam]

Yeah, its a common convention indeed. That said we generally don't have to worry about the position of the buttons. If we just specify the positive and negative actions correctly, that should do. Here positive actions corresponds to "Confirming actions" and negative action corresponds to the "Dismissive actions" in the material design guideline.

Just an FYI, this issue was created from a discussion that happened at #3397 . The relevant discussion starts from #3397 (comment). This was created to discuss the rationale behind why the buttons are the way they are now, if there are any reasons.

[madhurgupta10]

@glitch101 Do tag the comment or issue in your description, it will accelerate the discussion.

[aryan-earth]

Just an FYI, this issue was created from a discussion that happened at #3397 . The relevant discussion starts from #3397 (comment). This was created to discuss the rationale behind why the buttons are the way they are now, if there are any reasons.

Can I put this subsection of your comment in the description?

[aryan-earth]

@glitch101 Do tag the comment or issue in your description, it will accelerate the discussion.

Thanks for the tip. I will do that :)

[sivaraam]

Can I put this subsection of your comment in the description?

Sure. Here's the non-rendered markdown text of that part:

Just an FYI, this issue was created from a discussion that happened at https://github.com/commons-app/apps-android-commons/issues/3397 . The relevant discussion starts from https://github.com/commons-app/apps-android-commons/issues/3397#issuecomment-589927150. This was created to [discuss _the rationale behind why_ the buttons](https://github.com/commons-app/apps-android-commons/issues/3397#issuecomment-590108849) are the way they are now, if there are any reasons.

[misaochan]

Wow, #3397 is a really long discussion thread... I'm still halfway through it, but for this issue I think it is safe to say that it is OK to swap the buttons as per common conventions.

[aryan-earth]

Wow, #3397 is a really long discussion thread... I'm still halfway through it, but for this issue I think it is safe to say that it is OK to swap the buttons as per common conventions.

Yes, #3397 contains quite a lot of unrelated discussion with respect to this issue. I have updated the issue description to include the links to relevant discussion on #3397 thread.

[sivaraam]

Wow, #3397 is a really long discussion thread.

Yeah. Sorry about that! 😅

... but for this issue I think it is safe to say that it is OK to swap the buttons as per common conventions.

If we're ok with swapping the "Yes" and "No" in showAlertDialog(Activity, String, String, Runnable, Runnable onNegativeBtnClick, View, boolean), I think there are at least two usages of that method which we have to update to ensure the "Yes" remains as the negative action. Yeah, you read that right I did say negative action. I realize it's common to have "Yes" as the positive action but in the following cases I strongly believe it's more appropriate to have "Yes" as the negative action:

• UploadMediaDetailFragment.java#L352
• UploadMediaDetailFragment.java#L370

[FawziyahAlebiosu]

This is definitely an interesting issue, @glitch101 can you assign this to me?

[aryan-earth]

This is definitely an interesting issue, @glitch101 can you assign this to me?

Sorry, I cannot assign an issue to you. I do not have write access to this repository. I am a contributor. I am tagging one of the maintainers so that they can assign you. @maskaravivek

[sivaraam]

@FawziyahAlebiosu You can take this up. I've assigned this to you. Be sure to let us know how you get on :)