[Bug]: Error occurred while loading images

[prototyperspective]

Summary

Searching for luna or lunar but not lun does not load any images and shows the short info "Error occurred while loading images." The same error is shown again when taping onto "Load more". It also occurs for some other search terms but many searches work well.

Steps to reproduce

1. Open the latest version of the app
2. Enter e.g. luna into the search bar

Expected behaviour

It should show image and video and audio results

Actual behaviour

It doesn't show any results but shows this error

Device name

No response

Android version

Android 11

Commons app version

5.2.0

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

Prefer not

[nicolas-raoul]

I can reproduce:

[prototyperspective]

Thanks for looking into it. It now has an error loading images (not the same error) already when starting up the app. So when starting it an error is shown and no image is loaded. That may be related to this issue, this occurred today but not yesterday.

[Jason-Whitmore]

This bug seems to happen when loading images that have a high width to height ratio. When ImageInfo.updateThumbUrl() is called on these images, the code inside the if statements are run. The lastIndexOf() method sometimes returns -1, causing the subsequent replace method to throw an IndexOutOfBounds exception, crashing the thread and causing the error message to appear.

A simple fix would be to comment out the only call of updateThumbURL(). This appears to prevent the error and very wide images can be loaded successfully. The image is very short on the screen to accommodate the width. See example below:

Searching for "lunar":

I could easily make a PR for the simple fix, but maybe retrieving a bigger thumbnail is important and updateThumbURL() needs to be fixed rather than becoming an uncalled method.

[nicolas-raoul]

Thanks for the great investigation!
Any drawback to not using updateThumbURL()?

[Jason-Whitmore]

As far as I can tell, the only drawback to not using a fixed updateThumbURL() appears when viewing panoramic image thumbnails in the search results list. The thumbnail is in a very low resolution because the image is scaled up. See below, and especially the "Kazbeg Panorama" thumbnail:

Also, even if updateThumbURL() was fixed to properly retrieve a higher resolution thumbnail, it may cause unwanted network usage for the app's users.

[nicolas-raoul]

Ah yes, I remember that was an issue a long time ago. Better try and fix the method as you said, then. 🙂