Nearby List: Only show place cards with loaded names #6301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Generated APK variants! |
RitikaPahwa4444
approved these changes
May 4, 2025
There was a problem hiding this comment.
Tested. I am no longer getting an empty list. Thanks @andy-ife :)
sonalyadav1
pushed a commit
to sonalyadav1/apps-android-commons
that referenced
this pull request
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes the empty place cards that sometimes appeared in the Nearby list while places were loading.
Fixes #6268
Changes made
Tests performed
Tested prodDebug, betaDebug on a TECNO Spark 10c with API level 31.