Skip to content

Conversation

rohit9625
Copy link
Collaborator

Description (required)

Fixes #6236

What changes did you make and why?

  • I added a ProGuard rule to prevent obfuscating file usages related to classes in release variants, as the Gson serialization was silently failing.
  • Also, upgraded the lifecycle-runtime dependency version to 2.8.7 because I encountered a build failure due to lint errors after adding the ProGuard rule.

Tests performed (required)

Tested prodRelease on Pixel 6 with API level 34.

Screenshots (for UI changes only)

@nicolas-raoul
Copy link
Member

Would you mind removing app/src/main/res/values-x-invalidLanguageCode , to allow CI to run? Thanks! 🙂

@rohit9625

This comment was marked as resolved.

@rohit9625
Copy link
Collaborator Author

Done 👍

Copy link

✅ Generated APK variants!

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Actually if obfuscation is a recurrent issue and if it does not bring significant benefits in terms of app size/memory, then I am not against disabling it completely. It might also make some aspects of debugging easier? though are stack trace are currently rather readable.

@nicolas-raoul nicolas-raoul merged commit 5d7f42d into commons-app:main Jun 24, 2025
1 check passed
@rohit9625
Copy link
Collaborator Author

rohit9625 commented Jun 24, 2025

Thanks! Actually if obfuscation is a recurrent issue and if it does not bring significant benefits in terms of app size/memory, then I am not against disabling it completely. It might also make some aspects of debugging easier? though are stack trace are currently rather readable.

I wouldn't prefer that because Obfuscation do reduce the size of the APK and also remove unused code, logs, etc., in the release variant which isn't done then it will result in very bad performance of the app, specifically on low-end devices.

@rohit9625 rohit9625 deleted the fix/file-usage-not-working branch July 2, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: file usage does not work
2 participants