Optimise SPARQL query for single entity metadata using wikibase:label #6376
Conversation
… service - Use SERVICE wikibase:label for efficient retrieval of labels and descriptions in preferred language - Remove redundant label/description fetching logic - Prevent Cartesian product and improve query performance for
| OPTIONAL {?item rdfs:label ?itemLabelAnyLanguage} | ||
| BIND(COALESCE(?itemLabelPreferredLanguage, ?itemLabelAnyLanguage, "?") as ?label) | ||
| # Get item label/class label/description in the preferred language of the user | ||
| SERVICE wikibase:label { bd:serviceParam wikibase:language "${LANG},en". } |
There was a problem hiding this comment.
Let's say my phone is in French and I am visiting Japan.
So, ${LANG} is fr and most of the items around me only have labels in Japanese.
With this code, I do not see any label on most of the items, unfortunately (see screenshot).
A solution for this can be to append all possible Wikidata languages to that string. I will increase maintenance a bit as language codes are added/removed/modified from time to time, but that's a reasonable solution.
|
@nicolas-raoul I’ve added all assigned Wikidata languages to the label service for better coverage. |
done! |
|
✅ Generated APK variants! |
|
Since merging this, when uploading a picture near a QID, I get this: There should be a place name just before the interrogation point. Maybe due to variable renaming? Not sure though. The problem does not happen with the commit just before merging. Would you mind checking? You can create a new issue. |
Will check and create a new issue. |
Description (required)
Previously, super-popular items (e.g., Eiffel Tower) caused SPARQL query timeouts due to inefficient label and description fetching, resulting in grey pins and missing metadata in the app.
Fixes #6064
What changes did you make and why?
Optimized the SPARQL query for single entity metadata by using the wikibase:label service for efficient retrieval of labels and descriptions in the user's preferred language. Removed redundant label/description fetching logic to prevent Cartesian product and improve query performance, especially for super-popular items.
Tests performed (required)
Tested {build variant, ProdDebug} on {VIVO V25} with API level {35}.