Correct NearbyResultItem label mapping for place name display #6382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Generated APK variants! |
nicolas-raoul
approved these changes
Jul 25, 2025
Closed
|
Actually Nearby does not work anymore with this commit, labels are not shown for any pin, and many pins stay grey (presumably pins that should be red) 😱 |
|
I created #6383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6379
What changes did you make and why?
1)Updated the NearbyResultItem model to correctly map the
labelfield from the API response using@SerializedName("label").2)This ensures that the place name is properly parsed and displayed in the Nearby popup and related UI.
Tests performed (required)
Tested {build variant, ProdDebug} on {VIVO V25} with API level {35}.