SDK-60: update endpoints in WorkflowResource.java #45
Conversation
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
| return resp.getData(); | ||
| } | ||
|
|
||
| Workflow testWorkflow(WorkflowTestRequest req) { |
There was a problem hiding this comment.
in OrkesWorkflowClient it was already there. Using Conductor WorkflowClient.
| return resp.getData(); | ||
| } | ||
|
|
||
| void deleteWorkflow(String workflowId, Boolean archiveWorkflow) { |
There was a problem hiding this comment.
already existed in OrkesWorkflowClient
| client.execute(request); | ||
| } | ||
|
|
||
| void resumeWorkflow(String workflowId) { |
There was a problem hiding this comment.
already exists in OrkesWorkflowClient
|
@EugeneKisel-sm, Do you plan to cover workflow endpoints with e2e tests soon? Should I cover them with integration first? |
|
@IvanKulik-sm I do plan to cover all endpoints with e2e tests, but it is better to add at least 1 happy path integration test for every new endpoint |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| return workflowResource.getExecutionStatus(workflowId, includeTasks, summarize); | ||
| } | ||
|
|
||
| public void jumpToTask(String workflowId, String taskReferenceName, Map<String, Object> input) { |
There was a problem hiding this comment.
We officially do not support this. Lets remove.
… the workflow is not yet started
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered