-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add default runtime flags in config #26892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,7 @@ import ( | |
enchelpers "github.com/containers/ocicrypt/helpers" | ||
"github.com/containers/podman/v5/cmd/podman/registry" | ||
"github.com/containers/podman/v5/cmd/podman/utils" | ||
"github.com/containers/podman/v5/libpod" | ||
"github.com/containers/podman/v5/pkg/domain/entities" | ||
"github.com/containers/podman/v5/pkg/env" | ||
"github.com/openshift/imagebuilder" | ||
|
@@ -453,6 +454,12 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *Buil | |
runtimeFlags = append(runtimeFlags, "--systemd-cgroup") | ||
} | ||
|
||
configIndex := libpod.RuntimeNameToConfigIndex(podmanConfig.RuntimePath) | ||
|
||
for _, arg := range podmanConfig.ContainersConfDefaultsRO.Engine.OCIRuntimesFlags[configIndex] { | ||
runtimeFlags = append(runtimeFlags, "--"+arg) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this is right, compared to podmanConfig.RuntimeFlags this will always append. I would assume if we set --runtime-flag on the cli it should overwrite the config file and not always add as append? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would make it hard to have system-wide configuration default (e.g. logging options or whatever), and set unrelated options preserving the system-wide default. |
||
} | ||
|
||
platforms, err := parse.PlatformsFromOptions(c) | ||
if err != nil { | ||
return nil, err | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you cannot import libpod into the remote client, this function would need to live elsewhere but really I would say just inline this