Skip to content

Fix podman build "newer" pull policy #27005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix podman build "newer" pull policy #27005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a19307f
Fix podman build "newer" pull policy
zifeitong Sep 6, 2025
58e99d6
Add system test
zifeitong Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/podman/common/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,10 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *Buil
pullPolicy = buildahDefine.PullNever
}

if strings.EqualFold(strings.TrimSpace(flags.Pull), "newer") {
pullPolicy = buildahDefine.PullIfNewer
}

var cleanTmpFile bool
flags.Authfile, cleanTmpFile = buildahUtil.MirrorToTempFileIfPathIsDescriptor(flags.Authfile)
if cleanTmpFile {
Expand Down
56 changes: 56 additions & 0 deletions test/system/070-build.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

load helpers
load helpers.network
load helpers.registry

@test "podman build - basic test" {
rand_filename=$(random_string 20)
Expand Down Expand Up @@ -951,6 +952,61 @@ EOF
"--pull-never fails with expected error message"
}

@test "podman build --pull=newer" {
skip_if_remote "tests depend on start_registry which does not work with podman-remote"
start_registry

local registry=localhost:${PODMAN_LOGIN_REGISTRY_PORT}
local image_for_test=$registry/i-$(safename):$(random_string)
local authfile=$PODMAN_TMPDIR/authfile.json
local tmpdir=$PODMAN_TMPDIR/build-test

run_podman login --authfile=$authfile \
--tls-verify=false \
--username ${PODMAN_LOGIN_USER} \
--password ${PODMAN_LOGIN_PASS} \
$registry

# Generate a test image and push it to the registry.
# For safety in parallel runs, test image must be isolated
# from $IMAGE. A simple add-tag will not work. (#23756)
run_podman create -q $IMAGE true
local tmpcid=$output
run_podman commit -q $tmpcid $image_for_test
run_podman rm $tmpcid
run_podman image push --tls-verify=false --authfile=$authfile $image_for_test

local tmpdir=$PODMAN_TMPDIR/build-test
mkdir -p $tmpdir

# Now build using $image_for_test
cat >$tmpdir/Containerfile <<EOF
FROM $image_for_test
EOF

# Build the image
run_podman build $tmpdir --pull=newer --tls-verify=false --authfile=$authfile
is "$output" ".*pull" "pull seen in log"
is "$output" ".*COMMIT" "COMMIT seen in log"

# Build again
run_podman build $tmpdir --pull=newer --tls-verify=false --authfile=$authfile
assert "$output" !~ "pull" "should not pull the image again"

# Now refresh the remote image
run_podman create -q $IMAGE true
local tmpcid=$output
run_podman commit -q $tmpcid $image_for_test
run_podman rm $tmpcid
run_podman image push --tls-verify=false --authfile=$authfile $image_for_test

# Build one more time
run_podman build $tmpdir --pull=newer --tls-verify=false --authfile=$authfile
is "$output" ".*pull" "pull seen in log"

run_podman image rm --ignore $image_for_test
}

@test "podman build --logfile test" {
tmpdir=$PODMAN_TMPDIR/build-test
mkdir -p $tmpdir
Expand Down