fix(emulation): avoid nil pointer dereference in registeredBinfmtMisc #27014
Conversation
pkg/emulation/binfmtmisc_linux.go
Outdated
| if d == nil { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
That does not seem quite right logically, WalkDir() does not pass path, nil, nil if the dir doesn't exist. It passes path, nil, ErrNotExist. So the bug is actually on the lines above. We should not ignore ErrNotExist but rather handle gracefully and return nil.
if err != nil {
if errors.Is(err, os.ErrNotExist) {
return nil
}
return err
}
When `/proc/sys/fs/binfmt_misc` is not mounted, filepath.WalkDir may pass a nil DirEntry. This caused podman info to panic. Add a nil check to avoid dereferencing it. Signed-off-by: Peiyuan Song <[email protected]>
|
Can you update your commit message as well as this is not the case and you now do the right error handling. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, SquallATF The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
When
/proc/sys/fs/binfmt_miscis not mounted, filepath.WalkDir may pass a nil DirEntry. This caused podman info to panic. Add a nil check to avoid dereferencing it.Does this PR introduce a user-facing change?