-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix #27015. Document ServiceName #27019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eulores The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ServiceName defaults to quadlet name. Signed-off-by: Andreas <[email protected]>
ServiceName defaults to quadlet name. Signed-off-by: Andreas <[email protected]>
According to source file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can you please add "Fixes: #27015" to your PR description |
Yes, this is correct as they are considered the main services. Can you think of a way of using a template for this key? Most of the description is repetitive |
I think the |
Does this PR introduce a user-facing change?