Skip to content

Conversation

eulores
Copy link
Contributor

@eulores eulores commented Sep 8, 2025

Does this PR introduce a user-facing change?

None

Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eulores
Once this PR has been reviewed and has the lgtm label, please assign l0rd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ServiceName defaults to quadlet name.

Signed-off-by: Andreas <[email protected]>
ServiceName defaults to quadlet name.

Signed-off-by: Andreas <[email protected]>
@eulores
Copy link
Contributor Author

eulores commented Sep 8, 2025

According to source file podman/pkg/systemd/quadlet/quadlet.go, lines 1474..., both .container and .kube quadlets take their service name straight from the quadlet name, no suffix added.

Copy link
Collaborator

@ninja-quokka ninja-quokka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eulores

It seems one of your commits doesn't have the sign off: 7fcd30d

You can either squash your commits or amend that single commit and force push.

This update is great, surprising about kube and container service file naming.

@ninja-quokka
Copy link
Collaborator

Also can you please add "Fixes: #27015" to your PR description

@ygalblum
Copy link
Contributor

ygalblum commented Sep 8, 2025

both .container and .kube quadlets take their service name straight from the quadlet name, no suffix added.

Yes, this is correct as they are considered the main services.

Can you think of a way of using a template for this key? Most of the description is repetitive

@baude
Copy link
Member

baude commented Sep 9, 2025

I think the @@option usage may help with the repetition ? You also need to sign your commits; consider git commit -s --amend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants