Skip to content

Fix resolving assembly issue for Microsoft.Extensions.DependencyInjection.Abstractions #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2024
Merged

Fix resolving assembly issue for Microsoft.Extensions.DependencyInjection.Abstractions #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbcc424
changed order of assembly resolvers
daveMueller May 4, 2024
9284c42
update change log
DavidMuellerGetinge May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Documentation/Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Unreleased

### Fixed
- Fix Unable to instrument module - NET 8 [#1631](https://github.com/coverlet-coverage/coverlet/issues/1631)
- Fix slow modules filtering process [#1646](https://github.com/coverlet-coverage/coverlet/issues/1646) by https://github.com/BlackGad
- Fix incorrect coverage await using in generic method [#1490](https://github.com/coverlet-coverage/coverlet/issues/1490)

Expand Down
2 changes: 1 addition & 1 deletion src/coverlet.core/Instrumentation/CecilAssemblyResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ public NetstandardAwareAssemblyResolver(string modulePath, ILogger logger)
// runtime folders are different
_compositeResolver = new Lazy<CompositeCompilationAssemblyResolver>(() => new CompositeCompilationAssemblyResolver(new ICompilationAssemblyResolver[]
{
new NetCoreSharedFrameworkResolver(modulePath, _logger),
new AppBaseCompilationAssemblyResolver(),
new PackageCompilationAssemblyResolver(),
new NetCoreSharedFrameworkResolver(modulePath, _logger),
new ReferenceAssemblyPathResolver(),
}), true);
}
Expand Down