ResourceDiscovery: This patch adds a new resource discovery mechanism. #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention is to allow for a way to advertise the existence of resources at the OCM server. Signed-off-by: Micke Nordin <[email protected]>
| { | ||
| "server": "OCM Server 1", | ||
| "resources": [ | ||
| { |
There was a problem hiding this comment.
maybe individual resources could be aligned to protocol in Discovery? E.g. when a resource is only available via webdav, webapp or some other protocol?
How do I know if I need to send a ShareRequest as in #194 ?
|
I tried fixing the merge conflict and line length, failed on the line length 😅 |
IETF-RFC.md
Outdated
| * OPTIONAL: `rocrate` - an embedded JSON object following the | ||
| [ROCRATE](https://www.researchobject.org/ro-crate/specification/1.1/data-entities.html) | ||
| data-entities specification. | ||
| * REQUIRED: `id` - the unique identifier of the resource at the OCM Server |
There was a problem hiding this comment.
It's nitpicking on my side, I think we should keep the names consistent across the endpoints.
The providerId is from share creation
Suggested change
| * REQUIRED: `id` - the unique identifier of the resource at the OCM Server | |
| * REQUIRED: `providerId` - the unique identifier of the resource at the OCM Server |
There was a problem hiding this comment.
@KrausMatthias yes, I think it should have name like resourceId or something like that instead of providerId
and this is #196 😄
Co-authored-by: Mahdi Baghbani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to allow for a way to advertise the existence of resources at the OCM server.