Skip to content

Fixing preserving linux file permissions #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Fixing preserving linux file permissions #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion headers/entryHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ module.exports = function () {

// get Unix file permissions
get fileAttr() {
return uint16(_attr >> 16) & 0xfff;
return (_attr || 0) >> 16 & 0xfff;
},

get offset() {
Expand Down
10 changes: 10 additions & 0 deletions test/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,16 @@ describe("headers", () => {
expect(head.toJSON()).to.eql(headerdata);
});

it("handles fileAttr when attr above 0x80000000", () => {
const attr = 0x81E80000;

const head = new centralHeader();
head.loadFromBinary(readBuf);
head.attr = attr;

expect(head.fileAttr).to.equal(0x01E8);
});

it("read binary and create new binary from it, they have to be equal", () => {
const head = new centralHeader();
head.loadFromBinary(readBuf);
Expand Down