ndjson message - Add hook type to message

[grasshopper7]

Is your feature request related to a problem? Please describe.
The hook type (before, beforestep .... etc) is not available in the ndjson message. Need it in the reports to identify the hook type. Also for enabling or disabling display based on hook type.

Describe the solution you'd like
Available in the hook message. Will make porting reports based on json easier, in which this information is available.

Describe alternatives you've considered

Additional context

[aslakhellesoy]

I think this would be good to have. I’d like the type to be an enum so we avoid proliferation of types.

[grasshopper7]

Would something like this work?

message Hook {
  string id = 1;
  string tag_expression = 2;
  SourceReference source_reference = 3;
  HookType hook_type = 4;
  
  enum HookType {
    UNKNOWN = 0;
    BEFORE = 1;
    AFTER = 2;
    BEFORE_STEP = 3;
    AFTER_STEP = 4;
  }
}

Tried this with Java and getting the below message.

id: "42886b52-18d4-4e93-948b-c8b8b766ac99"
source_reference {
  location {
    line: 582
  }
  java_stack_trace_element {
    class_name: "MockedScenarioScopedHookDefinition"
    method_name: "getSourceReference"
    file_name: "CachingGlueTest.java"
  }
}
hook_type: BEFORE

[davidjgoss]

@grasshopper7 that looks good. Think it would also need BEFORE_ALL and AFTER_ALL

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.

[luke-hill]

@mpkorstanje - I think you were working on something that would effectively close this as completed?

[mpkorstanje]

I was. I needed these to implement a message protocol based json formatter. But I'm blocked on until I solve other problems. If any one wants this, feel free to pick up #224.