Skip to content

Conversation

cwalsh2189
Copy link
Contributor

Description

Currently the bulk publish metadata is only applied to the BulkPublishRequest object and not the individual messages within. Attaching the metadata to the individual messages as well so they can be applied when those are read.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1421

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • [] Extended the documentation

@cwalsh2189 cwalsh2189 requested review from a team as code owners January 6, 2025 21:42
@cwalsh2189
Copy link
Contributor Author

I was not sure what the full expectation for this change would be so wanted some feedback. It appears that this is impacting all consumers and not just Azure/Service Bus as in the open issue. We utilize AWS SNS/SQS and are seeing the same thing.

I went the route of applying the metadata to each individual message and leaving it at the top level, but not sure if that is still necessary/required, or if that piece should be removed.

@cwalsh2189 cwalsh2189 changed the title [WIP] attach metadata to each individual message in bulkpublish if it exists Attach metadata to each individual message in bulkpublish, if it exists Jan 14, 2025
@WhitWaldo WhitWaldo added this to the v1.16 milestone Feb 28, 2025
@WhitWaldo WhitWaldo added needs-review kind/bug Something isn't working and removed kind/bug Something isn't working needs-review labels Feb 28, 2025
@WhitWaldo WhitWaldo changed the base branch from master to release-1.16 April 1, 2025 22:38
@WhitWaldo
Copy link
Contributor

I was not sure what the full expectation for this change would be so wanted some feedback. It appears that this is impacting all consumers and not just Azure/Service Bus as in the open issue. We utilize AWS SNS/SQS and are seeing the same thing.

I went the route of applying the metadata to each individual message and leaving it at the top level, but not sure if that is still necessary/required, or if that piece should be removed.

I'll try to get this reviewed and merged in the next couple of weeks! Thank you for the contribution!

WhitWaldo added a commit to WhitWaldo/dapr-dotnet-sdk that referenced this pull request Apr 13, 2025
Signed-off-by: Whit Waldo <[email protected]>
@WhitWaldo WhitWaldo merged commit f588665 into dapr:release-1.16 Apr 13, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in v1.16 Release Tracking Board Apr 13, 2025
@WhitWaldo
Copy link
Contributor

Thank you very much for your contribution @cwalsh2189 !

@marcduiker
Copy link
Contributor

@holopin-bot @cwalsh2189 Thank you! Here's a digital badge as a small token of appreciation.

Copy link

holopin-bot bot commented Jun 11, 2025

Congratulations @cwalsh2189, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs0k7ah098007l1i1mztyqn

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

WhitWaldo added a commit to WhitWaldo/dapr-dotnet-sdk that referenced this pull request Aug 12, 2025
…ts (dapr#1437)

* Instead of just attaching metadata to the full envelope, the metadata is attached to each individual message as well, if it exists at all.

Signed-off-by: Chris Walsh <[email protected]>
Co-authored-by: Whit Waldo <[email protected]>
WhitWaldo added a commit to WhitWaldo/dapr-dotnet-sdk that referenced this pull request Aug 13, 2025
…ts (dapr#1437)

* Instead of just attaching metadata to the full envelope, the metadata is attached to each individual message as well, if it exists at all.

Signed-off-by: Chris Walsh <[email protected]>
Co-authored-by: Whit Waldo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Service Bus: Bulk publish does not apply metadata properties to events
4 participants