-
Notifications
You must be signed in to change notification settings - Fork 361
Attach metadata to each individual message in bulkpublish, if it exists #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chris Walsh <[email protected]>
I was not sure what the full expectation for this change would be so wanted some feedback. It appears that this is impacting all consumers and not just Azure/Service Bus as in the open issue. We utilize AWS SNS/SQS and are seeing the same thing. I went the route of applying the metadata to each individual message and leaving it at the top level, but not sure if that is still necessary/required, or if that piece should be removed. |
I'll try to get this reviewed and merged in the next couple of weeks! Thank you for the contribution! |
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Thank you very much for your contribution @cwalsh2189 ! |
@holopin-bot @cwalsh2189 Thank you! Here's a digital badge as a small token of appreciation. |
Congratulations @cwalsh2189, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs0k7ah098007l1i1mztyqn This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
…ts (dapr#1437) * Instead of just attaching metadata to the full envelope, the metadata is attached to each individual message as well, if it exists at all. Signed-off-by: Chris Walsh <[email protected]> Co-authored-by: Whit Waldo <[email protected]>
…ts (dapr#1437) * Instead of just attaching metadata to the full envelope, the metadata is attached to each individual message as well, if it exists at all. Signed-off-by: Chris Walsh <[email protected]> Co-authored-by: Whit Waldo <[email protected]>
Description
Currently the bulk publish metadata is only applied to the BulkPublishRequest object and not the individual messages within. Attaching the metadata to the individual messages as well so they can be applied when those are read.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1421
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: