-
Notifications
You must be signed in to change notification settings - Fork 459
[Internal] Make databricks_share_pluginframework
SDKv2 compatible
#4965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
approved these changes
Aug 22, 2025
Failing tests are unrelated, they are failing on main |
databricks_share_pluginframework
SDKv2 compatible
mgyucht
approved these changes
Sep 11, 2025
nkvuong
reviewed
Sep 12, 2025
internal/providers/pluginfw/products/sharing/resource_acc_test.go
Outdated
Show resolved
Hide resolved
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Sep 17, 2025
## Release v1.90.0 ### New Features and Improvements * Added `no_wait` option for `databricks_sql_endpoint` to skip waiting to start on warehouse creation ([#5014](#5014)) ### Bug Fixes * Remove incorrect customization for `databricks_catalog` ([#5021](#5021)) * Fix filling of `active` attribute in `databricks_user` data source ([#5026](#5026)) * Add support for share resource in plugin framework implementation to be SDKv2 compatible ([#4965](#4965)) ### Internal Changes * Use `Jobs.Get` instead of `JobsGetByJobId` ([#5029](#5029))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Plugin framework implementation of share resource is not compatible with SDKv2. Compatibility difference arises because of how these libraries apply the changes internally:
Plugin Framework checks if the state is null for creation: https://github.com/hashicorp/terraform-plugin-framework/blob/main/internal/fwserver/server_applyresourcechange.go#L47
Whereas SDKv2 checks the ID: https://github.com/hashicorp/terraform-plugin-sdk/blob/main/helper/schema/resource.go#L976
Because of the incompatibility, SDKv2 re-creates the share resource after it has been created by plugin framework. The PR adds the ID field as part of schema. This change makes the plugin framework implementation compatible with SDKv2
Tests