Skip to content

Add GitHub Publish action that executes manually with workflow_dispatch #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2021
Merged

Add GitHub Publish action that executes manually with workflow_dispatch #131

merged 2 commits into from
Jul 27, 2021

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jul 27, 2021

No description provided.

@mofojed mofojed self-assigned this Jul 27, 2021
@mofojed mofojed requested a review from mattrunyon July 27, 2021 21:14
@mofojed mofojed added this to the July 2021 milestone Jul 27, 2021
@mofojed mofojed requested review from spasovski and removed request for mattrunyon July 27, 2021 21:14
@mofojed mofojed marked this pull request as ready for review July 27, 2021 21:14
@mofojed
Copy link
Member Author

mofojed commented Jul 27, 2021

I tested this by running the action in my own repo: https://github.com/mofojed/web-client-ui/runs/3176022351?check_suite_focus=true
It failed at the actual publishing part, because my GITHUB_TOKEN in my fork won't allow me to publish packages to the deephaven organization, but in this repo it should work correctly. I can't dispatch the workflow action until it's been merged to main though (even though you can pick a branch to run it from).

spasovski
spasovski approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@spasovski spasovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at a glance.

@mofojed mofojed merged commit 4d67c7d into deephaven:main Jul 27, 2021
@mofojed mofojed deleted the publish-alpha branch July 27, 2021 22:01
@mofojed mofojed mentioned this pull request Jul 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@spasovski spasovski spasovski approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mofojed mofojed

Labels
internal
Projects
None yet
Milestone
July 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@mofojed @spasovski