refactor!: OllamaChatGenerator - refine reasoning support + refactoring
#2200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:ollama
type:documentation
anakin87
changed the title
OllamaChatGenerator - refine reasoning support
anakin87
commented
Aug 20, 2025
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
anakin87
changed the title
OllamaChatGenerator - refine reasoning supportOllamaChatGenerator - refine reasoning support + refactoring
sjrl
reviewed
Aug 22, 2025
Comment on lines
+176
to
+181
| content=content, | ||
| meta=meta, | ||
| index=index, | ||
| finish_reason=finish_reason, | ||
| component_info=component_info, | ||
| tool_calls=tool_calls_list, |
There was a problem hiding this comment.
I realized we aren't utilizing the start in StreamingChunk. Any reason for that?
There was a problem hiding this comment.
I see that we set start in _handle_streaming_response but only for tool_calls. It should also be set to True for the beginnings of normal text blocks and I can't immediately tell if that's happening or not.
sjrl
reviewed
Aug 22, 2025
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
sjrl
reviewed
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
reasoning refinements
ChatMessagecontent instead ofmetarefactoring: since we remove reasoning from
meta, this is breaking change and we need to release a major version, so I took the opportunity to do some refactoringorca-miniis very outdated, whileqwen3:0.6bis a small model, capable of tool calling and reasoningHow did you test it?
CI
I have manually verified and written tests for:
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.