Skip to content

Docs: Update OpenAIGen docstrings and add missing headers #8105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2024
Merged

Docs: Update OpenAIGen docstrings and add missing headers #8105

merged 4 commits into from
Jul 30, 2024

Conversation

agnieszka-m
Copy link
Contributor

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@agnieszka-m agnieszka-m added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jul 29, 2024
@agnieszka-m agnieszka-m requested a review from dfokina July 29, 2024 06:18
@agnieszka-m agnieszka-m requested a review from a team as a code owner July 29, 2024 06:18
@agnieszka-m agnieszka-m requested review from anakin87, a team and vblagoje and removed request for a team and anakin87 July 29, 2024 06:18
@github-actions github-actions bot added the type:documentation Improvements on the docs label Jul 29, 2024
@agnieszka-m agnieszka-m removed the request for review from vblagoje July 29, 2024 06:18
@coveralls
Copy link
Collaborator

coveralls commented Jul 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10157061691

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 90.059%
Files with Coverage Reduction New Missed Lines %
components/generators/openai.py 3 96.39%
Totals Coverage Status
Change from base Build 10144976547: 0.0%
Covered Lines: 6813
Relevant Lines: 7565
💛 - Coveralls

dfokina
dfokina requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@dfokina dfokina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one note

@agnieszka-m agnieszka-m requested a review from dfokina July 30, 2024 06:31
@dfokina dfokina merged commit e8598be into main Jul 30, 2024
14 checks passed
@dfokina dfokina deleted the openaigen-docstrings branch July 30, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfokina dfokina dfokina approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: clean up docstrings of OpenAIGenerator
3 participants
@agnieszka-m @coveralls @dfokina