Skip to content

Conversation

Ujjwal-Bajpayee
Copy link
Contributor

@Ujjwal-Bajpayee Ujjwal-Bajpayee commented Aug 28, 2025

Related Issues

Proposed Changes:

Expanded the State class docstring to explain its purpose as shared context for Agents and tools
Clarified how schema entries are defined (type, optional handler)
Added a minimal usage snippet for quick understanding

How did you test it?

Manual verification: built and imported the State class to ensure the docstring renders correctly

Notes for the reviewer

This change only affects documentation (no functional changes)

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@Ujjwal-Bajpayee Ujjwal-Bajpayee requested a review from a team as a code owner August 28, 2025 09:13
@Ujjwal-Bajpayee Ujjwal-Bajpayee requested review from davidsbatista and removed request for a team August 28, 2025 09:13
@github-actions github-actions bot added the type:documentation Improvements on the docs label Aug 28, 2025
@anakin87
Copy link
Member

See #9738 (comment)

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2025

CLA assistant check
All committers have signed the CLA.

@anakin87 anakin87 changed the title Docs: clarify purpose of State class (closes #9738) Docs: clarify purpose of State class Aug 28, 2025
@anakin87
Copy link
Member

While this won't fix #9738 (see #9738 (comment)), having a better docstring/API reference for this class won't hurt.

@sjrl could you take a look?

@anakin87 anakin87 requested a review from sjrl August 28, 2025 10:39
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 2, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17398848192

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.077%

Totals Coverage Status
Change from base Build 17378114148: 0.0%
Covered Lines: 12935
Relevant Lines: 14048

💛 - Coveralls

Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anakin87 anakin87 merged commit 0fe2f8e into deepset-ai:main Sep 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants