fix: Add csrc/compile to include paths for DeepCompile builder
#7401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since currently `z1.h`, `z2.h` and `z3.h` are located under
`csrc/compile`, without this patch, torch hipify will fail to
identify these hipified headers on AMD platform:
```log
In file included from torch/include/ATen/cuda/CUDAEvent.h:3,
from deepspeed/ops/csrc/includes/deepcompile.h:16,
from deepspeed/ops/csrc/compile/z1.h:6,
from deepspeed/ops/csrc/compile/z1_hip.cpp:7:
torch/include/ATen/cuda/ATenCUDAGeneral.h:3:10: fatal error: cuda.h: No such file or directory
3 | #include <cuda.h>
| ^~~~~~~~
compilation terminated.
```
Signed-off-by: Hollow Man <[email protected]>
lpnpcs
pushed a commit
to lpnpcs/DeepSpeed
that referenced
this pull request
Jul 30, 2025
…pspeedai#7401) Since currently `z1.h`, `z2.h` and `z3.h` are located under `csrc/compile`, without this patch, torch hipify will fail to identify these hipified headers on AMD platform: ```log In file included from torch/include/ATen/cuda/CUDAEvent.h:3, from deepspeed/ops/csrc/includes/deepcompile.h:16, from deepspeed/ops/csrc/compile/z1.h:6, from deepspeed/ops/csrc/compile/z1_hip.cpp:7: torch/include/ATen/cuda/ATenCUDAGeneral.h:3:10: fatal error: cuda.h: No such file or directory 3 | #include <cuda.h> | ^~~~~~~~ compilation terminated. ``` Signed-off-by: Hollow Man <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since currently
z1.h,z2.handz3.hare located undercsrc/compile, without this patch, torch hipify will fail to identify these hipified headers on AMD platform: