Fix KeyError in git credential configuration when host is missing #12973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This fixes a
KeyError: key not found: "host"
that occurs inSharedHelpers.configure_git_to_use_https_with_credentials
when processing credential entries that don't have a "host" key.The error was introduced in the recent changes to support Git rewrite rules without credentials. The code was calling
cred.fetch("host")
without first checking if the "host" key exists, causing crashes when malformed or incomplete credential entries are processed.Anything you want to highlight for special attention from reviewers?
Added a defensive check
next unless cred["host"]
before processing each credential entry. This approach:This is a minimal, safe fix that doesn't change the core functionality.
How will you know you've accomplished your goal?
Checklist